From owner-freebsd-hackers@FreeBSD.ORG Sun Apr 23 11:33:47 2006 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 29A9F16A400; Sun, 23 Apr 2006 11:33:47 +0000 (UTC) (envelope-from marco@goofy.tols.org) Received: from goofy.tols.org (goofy.demon.nl [83.160.134.92]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2364B43D45; Sun, 23 Apr 2006 11:33:45 +0000 (GMT) (envelope-from marco@goofy.tols.org) Received: from goofy.tols.org (localhost [127.0.0.1]) by goofy.tols.org (8.13.4/8.13.4) with ESMTP id k3NBXZ6G027454; Sun, 23 Apr 2006 11:33:35 GMT (envelope-from marco@goofy.tols.org) Received: (from marco@localhost) by goofy.tols.org (8.13.4/8.13.4/Submit) id k3NBXZ28027453; Sun, 23 Apr 2006 11:33:35 GMT (envelope-from marco) Date: Sun, 23 Apr 2006 11:33:35 +0000 From: Marco van Tol To: freebsd-hackers@freebsd.org Message-ID: <20060423113335.GA27406@tols.org> Mail-Followup-To: freebsd-hackers@freebsd.org, John Baldwin References: <20060412215021.GB1146@tols.org> <20060417134825.GA47043@tols.org> <20060418221505.GC58081@tols.org> <200604181838.27713.jhb@freebsd.org> <20060419072627.GA66012@tols.org> <20060420224049.GA99399@tols.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060420224049.GA99399@tols.org> User-Agent: Mutt/1.4.2.1i X-Virus-Scanned: ClamAV 0.88.1/1420/Sun Apr 23 01:02:06 2006 on goofy.tols.org X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=unavailable version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on goofy.tols.org Cc: Subject: Re: Per CPU cpu-statistics under SMP X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Apr 2006 11:33:47 -0000 On Fri, Apr 21, 2006 at 12:40:49AM +0200, Marco van Tol wrote: > On Wed, Apr 19, 2006 at 07:26:27AM +0000, Marco van Tol wrote: > > On Tue, Apr 18, 2006 at 06:38:26PM -0400, John Baldwin wrote: > > [...] > > > > Ah, hmm. On 6.x we don't have per-thread stat ticks yet, which is > > > probably why it is failing. It also isn't safe to move sched_lock > > > down either on 6.x. You can still apply the rest of the patch by > > > hand, just leave the 'mtx_lock_spin(&sched_lock)' where it is and > > > change all the 'cp_time[FOO]++' to 'PCPU_LAZY_INC(cp_time[FOO])'. > > > > OK, thanks. > > > > What I will do is replace my gentoo partition with a BSD current partition > > so I don't loose my workstation as it were, and use that to work on this. > > > > Will let you know how that goes. Thanks. > > Ha! It succeeded. :) [...] I got it to work in non-client/server mode, and am working on making it also work in client/server mode. (gkrellmd as opposed to gkrellm) Is there anything you can say regarding an estimate on when per-cpu specific stats will hit the official CURRENT and STABLE branches? Are you interested in what I did to gkrellm so far? All that was necessary was a small patch to src/sysdeps/freebsd.c in the gkrellm tree as far as making it work with your patch was concerned. I can send the patch to your email adres, or make it available on my website. :) Marco -- Gisteren is het niet gelukt.