Date: Tue, 07 Sep 2021 13:39:33 +0000 From: bugzilla-noreply@freebsd.org To: chromium@FreeBSD.org Subject: [Bug 258271] www/chromium: Makefile warning for grep mempcpy /usr/include/string.h. This warning is redundant and persistent. Message-ID: <bug-258271-28929-OS4Smcyaf3@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-258271-28929@https.bugs.freebsd.org/bugzilla/> References: <bug-258271-28929@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D258271 Robert Clausecker <fuz@fuz.su> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fuz@fuz.su --- Comment #8 from Robert Clausecker <fuz@fuz.su> --- (In reply to Tomoaki AOKI from comment #5) I'm not sure what you are missing. We have checked when this change was do= ne in base and the first OSVERSION bump after this change was two days later a= nd is the one found in the patch. So only if someone built an OS in the two d= ays between the commit and the OSVERSION bump the check would be wrong and then= in the harmless direction, i.e. not using mempcpy when it is available. What's wrong with doing it that way? It is sufficiently accurate, idiomatic (see =C2=A74.4 porter's handbook), fixes the warning, and improves performa= nce. They're not going to bump OSVERSION for every single commit, so I'm not sure what you are looking for. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-258271-28929-OS4Smcyaf3>