From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Dec 13 14:30:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 960B88D5 for ; Fri, 13 Dec 2013 14:30:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 714121DAF for ; Fri, 13 Dec 2013 14:30:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rBDEU094007831 for ; Fri, 13 Dec 2013 14:30:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rBDEU0MB007830; Fri, 13 Dec 2013 14:30:00 GMT (envelope-from gnats) Resent-Date: Fri, 13 Dec 2013 14:30:00 GMT Resent-Message-Id: <201312131430.rBDEU0MB007830@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Glen Barber Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DDFF57E2 for ; Fri, 13 Dec 2013 14:25:56 +0000 (UTC) Received: from oldred.freebsd.org (oldred.freebsd.org [IPv6:2001:1900:2254:206a::50:4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id CAAE51D79 for ; Fri, 13 Dec 2013 14:25:56 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id rBDEPu0n086794 for ; Fri, 13 Dec 2013 14:25:56 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id rBDEPuHl086783; Fri, 13 Dec 2013 14:25:56 GMT (envelope-from nobody) Message-Id: <201312131425.rBDEPuHl086783@oldred.freebsd.org> Date: Fri, 13 Dec 2013 14:25:56 GMT From: Glen Barber To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/184749: [patch] net-mgmt/nagios-plugins: Fix check_dns plugin on OSVERSION >= 1000000 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Dec 2013 14:30:00 -0000 >Number: 184749 >Category: ports >Synopsis: [patch] net-mgmt/nagios-plugins: Fix check_dns plugin on OSVERSION >= 1000000 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Dec 13 14:30:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Glen Barber >Release: FreeBSD 11.0-CURRENT r258761 >Organization: The FreeBSD Foundation >Environment: FreeBSD nucleus 11.0-CURRENT FreeBSD 11.0-CURRENT #194 r258761: Wed Dec 4 09:23:20 EST 2013 root@nucleus:/usr/obj/usr/src/sys/NUCLEUS amd64 >Description: check_dns.c hard-codes the path to nslookup(1) to /usr/bin/nslookup, which does not exist by default on head/, stable/10/, or releng/10.0/. This causes the check_dns plugin to fail, outputting the following: "DNS CRITICAL - '/usr/bin/nslookup -sil' msg parsing exited with no address" >How-To-Repeat: >Fix: Attached patch resolves the issue. Patch attached with submission follows: Index: net-mgmt/nagios-plugins/Makefile =================================================================== --- net-mgmt/nagios-plugins/Makefile (revision 336347) +++ net-mgmt/nagios-plugins/Makefile (working copy) @@ -3,6 +3,7 @@ PORTNAME= nagios-plugins PORTVERSION= 1.5 +PORTREVISION= 1 PORTEPOCH= 1 CATEGORIES= net-mgmt MASTER_SITES= https://www.nagios-plugins.org/download/ @@ -56,6 +57,10 @@ --sysconfdir=${PREFIX}/etc/nagios \ --localstatedir=${NAGIOSDIR} \ --prefix=${PREFIX} +.if(${OSVERSION} >= 1000000) +CONFIGURE_ARGS+=--with-nslookup-command=${PREFIX}/bin/nslookup +BUILD_DEPENDS+= nslookup:${PORTSDIR}/dns/bind-tools +.endif CONFIGURE_ENV= PERL=${PERL} CPPFLAGS+= -I${LOCALBASE}/include >Release-Note: >Audit-Trail: >Unformatted: