From nobody Tue Sep 30 15:37:15 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cbhy34yyNz69FRv; Tue, 30 Sep 2025 15:37:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cbhy340Xnz3TSv; Tue, 30 Sep 2025 15:37:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759246635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lVuxlW7iAdoDoiwxMRBJAKzIA8Jv2kRFAN+NGT/0XZk=; b=U/B0xshR/sWsa8XNsS25TRWIYCOpUMoa41WlfmiqqhCgsDid0rdrxLd2RI9b0ScCIwblim k969hoazJJEkvJKqxT7E00cEK+m7GqIUB/YL0WYDnAXOshx6XmLa8M5q+gYEiroZgVxo4D Zz9JJdKqhL3QG4s4dc9JxqVUQWnYkaxq8vC86YB53sCkbSrdSQBMixVDCs4OQYWydc1k6k obGbmrzKmh4kYNud90IN64v0Ru6YMPIpYnxqYDISA//GAl6Pol393YryQP7+qXLEGWH+zr 9CSxNHCMGVPbBfk57qYthGJRNFxvoC97VTljIODLnojTTkWsnRyoSOM8EkAgVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759246635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lVuxlW7iAdoDoiwxMRBJAKzIA8Jv2kRFAN+NGT/0XZk=; b=muUDRurDwJO4Or/Ts6WiAY7w1MHbswhEyE44MejCdz38dr7pEVEc29d0tIO44KxswyP2UX F91Pth5Q0cJ28etY2089+4JUOwFOBE/nXpyf5DOkHmJMsLzbJHPztJtHMlsg8CjvT1qndx bsnKct5Bfk+izdjsAkwLzaCQjCikUjf5bMAWcpDLZrmLMnUtJkCPdMQRRvR/rDR0Xeh0uZ 5fL3Q+qFRRYag0HTFciCNp5Lii2z9V34by07bbof51s9npExpiGlM0dTIS+S+OMt/P+RrM dOtsDCzFay+AnsHhaX+sMdjgSdRiSnh7Xm80/+Aj3pBeDdexeB3CVuRDggJEGQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759246635; a=rsa-sha256; cv=none; b=FCx5TiHeLaqVFGXeIp6HM4k6WXXSI2HRPlybj0/g2pEVFOVRnZUUuUr2kt9IXOnIArXBWH ahrhLA516E4hse8Szg+7QR6PZFI227YYknhY7eiYx2KfuT6iq3PUZliGb/ef7gYJ6uBl+a RVMQsGw9xkgSkbNqDLT2znuqsSG0NwEfsSf7SUEDlfkXY+gp5voMiWpy2BorxPijp73Ean PN6yan0VwyZKSXno/eo+Vrzd0jyVSi0o8I+tKhwVHaXHLIhDZtAB7U0dIRtJ92ynp+kGMB t9zOt/2Q1JfeGa+O+Okl4N3L4/HM8Xb/j+andVSzso4mJtCAqPUejwQkAjcA3g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cbhy33bgGzjgv; Tue, 30 Sep 2025 15:37:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58UFbFOn067514; Tue, 30 Sep 2025 15:37:15 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58UFbFNg067511; Tue, 30 Sep 2025 15:37:15 GMT (envelope-from git) Date: Tue, 30 Sep 2025 15:37:15 GMT Message-Id: <202509301537.58UFbFNg067511@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Gordon Tetlow Subject: git: 978e04ff5bcf - releng/14.3 - freebsd-update: Library ordering List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gordon X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.3 X-Git-Reftype: branch X-Git-Commit: 978e04ff5bcf0a750cd3ef19561f5e0f67860620 Auto-Submitted: auto-generated The branch releng/14.3 has been updated by gordon: URL: https://cgit.FreeBSD.org/src/commit/?id=978e04ff5bcf0a750cd3ef19561f5e0f67860620 commit 978e04ff5bcf0a750cd3ef19561f5e0f67860620 Author: Colin Percival AuthorDate: 2025-09-23 06:55:08 +0000 Commit: Gordon Tetlow CommitDate: 2025-09-30 04:57:23 +0000 freebsd-update: Library ordering Upgrading from 14.x to 15.x with freebsd-update broke because libc depends on the new libsys library; freebsd-update installed the new libc before creating libsys, and every step after that failed because all the tools (including gunzip and install) are dynamically linked and need a working libc. Enforce ordering when installing shared objects: First libsys, then libc, then libthr, and then all the rest of the shared object files. This is a candidate for an Errata Notice since the issue this fixes breaks upgrades. PR: 289769 Reported by: Graham Perrin Reviewed by: kib MFC after: 3 days Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D52688 Approved by: so Security: FreeBSD-EN-25:18.freebsd-update (cherry picked from commit 7ece602e00e85195fc426a2401c49921cd39735e) (cherry picked from commit e26928669f39c8683aea74040b9e2472e944c43a) --- usr.sbin/freebsd-update/freebsd-update.sh | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/usr.sbin/freebsd-update/freebsd-update.sh b/usr.sbin/freebsd-update/freebsd-update.sh index f575f89bcf82..cf314a256b81 100644 --- a/usr.sbin/freebsd-update/freebsd-update.sh +++ b/usr.sbin/freebsd-update/freebsd-update.sh @@ -3063,10 +3063,28 @@ Kernel updates have been installed. Please reboot and run grep -E '^/libexec/ld-elf[^|]*\.so\.[0-9]+\|' > INDEX-NEW install_from_index INDEX-NEW || return 1 - # Install new shared libraries next + # Next, in order, libsys, libc, and libthr. grep -vE '^/boot/' $1/INDEX-NEW | grep -vE '^[^|]+\|d\|' | grep -vE '^/libexec/ld-elf[^|]*\.so\.[0-9]+\|' | + grep -E '^[^|]*/lib/libsys\.so\.[0-9]+\|' > INDEX-NEW + install_from_index INDEX-NEW || return 1 + grep -vE '^/boot/' $1/INDEX-NEW | + grep -vE '^[^|]+\|d\|' | + grep -vE '^/libexec/ld-elf[^|]*\.so\.[0-9]+\|' | + grep -E '^[^|]*/lib/libc\.so\.[0-9]+\|' > INDEX-NEW + install_from_index INDEX-NEW || return 1 + grep -vE '^/boot/' $1/INDEX-NEW | + grep -vE '^[^|]+\|d\|' | + grep -vE '^/libexec/ld-elf[^|]*\.so\.[0-9]+\|' | + grep -E '^[^|]*/lib/libthr\.so\.[0-9]+\|' > INDEX-NEW + install_from_index INDEX-NEW || return 1 + + # Install the rest of the shared libraries next + grep -vE '^/boot/' $1/INDEX-NEW | + grep -vE '^[^|]+\|d\|' | + grep -vE '^/libexec/ld-elf[^|]*\.so\.[0-9]+\|' | + grep -vE '^[^|]*/lib/(libsys|libc|libthr)\.so\.[0-9]+\|' | grep -E '^[^|]*/lib/[^|]*\.so\.[0-9]+\|' > INDEX-NEW install_from_index INDEX-NEW || return 1