From owner-freebsd-bugs@freebsd.org  Sun Nov  5 21:23:37 2017
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DDDBAE527FD
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Sun,  5 Nov 2017 21:23:37 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id C39AB6CE8E
 for <freebsd-bugs@FreeBSD.org>; Sun,  5 Nov 2017 21:23:37 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vA5LNbNP017252
 for <freebsd-bugs@FreeBSD.org>; Sun, 5 Nov 2017 21:23:37 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 223440] world needs review and adjustment for the disabling of
 fallocate for zfs (-r325320), lld included
Date: Sun, 05 Nov 2017 21:23:37 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: emaste@freebsd.org
X-Bugzilla-Status: In Progress
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-223440-8-cpCjgPF63q@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-223440-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-223440-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Nov 2017 21:23:38 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223440

--- Comment #3 from Ed Maste <emaste@freebsd.org> ---
> contrib/sqlite3/sqlite3.c
> crypto/heimdal/lib/sqlite/sqlite3.c

AFAICT this is the only issue that needs more effort / investigation, as it
appears that it does not correctly handle EINVAL or EOPNOTSUPP:

#if defined(HAVE_POSIX_FALLOCATE) && HAVE_POSIX_FALLOCATE
      /* The code below is handling the return value of osFallocate()=20
      ** correctly. posix_fallocate() is defined to "returns zero on succes=
s,=20
      ** or an error number on  failure". See the manpage for details. */
      int err;
      do{
        err =3D osFallocate(pFile->h, buf.st_size, nSize-buf.st_size);
      }while( err=3D=3DEINTR );
      if( err ) return SQLITE_IOERR_WRITE;
#else

Other source files with posix_fallocate / fallocate do not have an issue:

> contrib/netbsd-tests/lib/libc/sys/t_posix_fallocate.c

It's only testing that posix_fallocate doesn't change errno, and that EBADF=
 is
returned for a bad fd (-1), so no issue here.

> contrib/llvm/lib/Support/Unix/Path.inc

Fixed by r325420

> contrib/pjdfstest/pjdfstest.c

Appears to be test harness only; I did not find a test invoking posix_fallo=
cate
or fallocate.

--=20
You are receiving this mail because:
You are the assignee for the bug.=