From owner-cvs-all Sat Jun 8 0: 1:19 2002 Delivered-To: cvs-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 931) id B2B0237B403; Sat, 8 Jun 2002 00:01:09 -0700 (PDT) Date: Sat, 8 Jun 2002 00:01:09 -0700 From: "J. Mallett" To: Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ps extern.h Message-ID: <20020608000108.A42463@FreeBSD.ORG> References: <200206080649.g586nFw91656@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200206080649.g586nFw91656@freefall.freebsd.org>; from bde@FreeBSD.org on Fri, Jun 07, 2002 at 11:49:15PM -0700 Organisation: The FreeBSD Project X-Alternate-Addresses: , , , X-Affiliated-Projects: FreeBSD, xMach, ircd-hybrid-7 X-Towel: Yes Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * From Bruce Evans > bde 2002/06/07 23:49:15 PDT > > Modified files: > bin/ps extern.h > Log: > Fixed unsorting. Now, I understand this project has a hard time deciding what exactly it means "to sort" something, but nonetheless I would have to say that this appears to replace one possibly acceptable sorting method (sorting by type) with a wrong sort order of another sorting method (sorting by variable name). In my mind, we should be sorting as per LANG=C, and in that case, 'ra' definitely comes a bit after 'no', however 'no' comes happily after 'nl', therefore the lines in this locate could be written as: %%% extern int cflag, eval, fscale, mempages, nlistread; extern time_t now; extern int rawcpu, sumrusage, termwidth, totwidth; %%% But I don't think revision 1.24 fixes unsorting. If I'm wrong I'd like to know so I don't wrongly sort things in the future. Thanks. -- J. Mallett FreeBSD: The Power To Serve "I've coined new words, like, misunderstanding and Hispanically." -- George W. Bush, Radio-Television Correspondents Association dinner, Washington, D.C., March 29, 2001 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message