Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 8 Jun 2002 00:01:09 -0700
From:      "J. Mallett" <jmallett@FreeBSD.org>
To:        Bruce Evans <bde@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/bin/ps extern.h
Message-ID:  <20020608000108.A42463@FreeBSD.ORG>
In-Reply-To: <200206080649.g586nFw91656@freefall.freebsd.org>; from bde@FreeBSD.org on Fri, Jun 07, 2002 at 11:49:15PM -0700
References:  <200206080649.g586nFw91656@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
* From Bruce Evans <bde@FreeBSD.org>
> bde         2002/06/07 23:49:15 PDT
> 
>   Modified files:
>     bin/ps               extern.h 
>   Log:
>   Fixed unsorting.

Now, I understand this project has a hard time deciding what exactly it means
"to sort" something, but nonetheless I would have to say that this appears to
replace one possibly acceptable sorting method (sorting by type) with a wrong
sort order of another sorting method (sorting by variable name).  In my mind,
we should be sorting as per LANG=C, and in that case, 'ra' definitely comes a
bit after 'no', however 'no' comes happily after 'nl', therefore the lines in
this locate could be written as:

%%%
extern int cflag, eval, fscale, mempages, nlistread;
extern time_t now;
extern int rawcpu, sumrusage, termwidth, totwidth;
%%%

But I don't think revision 1.24 fixes unsorting.

If I'm wrong I'd like to know so I don't wrongly sort things in the future.

Thanks.
-- 
J. Mallett <jmallett@FreeBSD.org>                    FreeBSD: The Power To Serve


	"I've coined new words, like, misunderstanding and Hispanically."
	   -- George W. Bush, Radio-Television Correspondents Association
	      dinner, Washington, D.C., March 29, 2001

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020608000108.A42463>