Date: Tue, 31 Jul 2018 22:18:42 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Emmanuel Vadot <manu@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337004 - head/sys/dev/ofw Message-ID: <20180731221842.GA79074@FreeBSD.org> In-Reply-To: <201807312050.w6VKoopE027843@repo.freebsd.org> References: <201807312050.w6VKoopE027843@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 31, 2018 at 08:50:50PM +0000, Emmanuel Vadot wrote: > New Revision: 337004 > URL: https://svnweb.freebsd.org/changeset/base/337004 > > Log: > ofw_cpu: Add support for getting cpu clock via clock property > > Nominal Mhz is either expressed via the clock-frequency property > ... > +#ifdef EXT_RESOURCES > + rv = clk_get_by_ofw_index(dev, 0, 0, &cpuclk); > + if (rv == 0) { > + rv = clk_get_freq(cpuclk, &freq); > + if (rv != 0 && bootverbose) > + device_printf(dev, > + "Cannot get freq of property clocks\n"); Why informal "freq" contraction, esp. when it's properly spelled out few lines below? > + if (bootverbose) > + device_printf(dev, > + "missing 'clock-frequency' property\n"); > } else > sc->sc_nominal_mhz = cell / 1000000; /* convert to MHz */ > > + if (sc->sc_nominal_mhz != 0 && bootverbose) > + device_printf(dev, "Nominal frequency %dMhz\n", I think correct spelling is MHz, not Mhz. Notice that comment above uses this spelling. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180731221842.GA79074>