From owner-freebsd-net@FreeBSD.ORG Tue Mar 20 17:45:34 2012 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 79403106566B; Tue, 20 Mar 2012 17:45:34 +0000 (UTC) (envelope-from nitroboost@gmail.com) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id 0BEB58FC14; Tue, 20 Mar 2012 17:45:33 +0000 (UTC) Received: by yhgm50 with SMTP id m50so397018yhg.13 for ; Tue, 20 Mar 2012 10:45:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=dGHlYepAZrnpJ8RFBvnuIIL8Ywv66DFwKtIiJa6DSnY=; b=ybzDMkoK86YWmesi+5ZTNyQLzhTeYLMPIK83H0dysJSnbAsgouDYGUQB9EKxJAAunk 50HYqGWTBCeSLa6Cdwfaqyr0+BjP/sRWhrY8/CgsVFv3a9sjradjO/Ip4ULMgPdyzmXk Kymy0BtrjkoOsxlEsiXZTlKv2V7iYeCC6n2SkQRXdvKbEVR7wyuG3hUyczDjKz1qOzAT t/wiBzLXp5GPlAR+tyIDgkLoOzRPXvYvNiCTetiFVvV/f6H59TyNRfY00E9sgd/+jkTT rGvwk49DYZu8vagermC4pk1n7+xBovfiRIDO37Uf/4ruEVzfbEy8vvJcBMduVBirhAPf 7Ijw== MIME-Version: 1.0 Received: by 10.60.18.137 with SMTP id w9mr1039037oed.7.1332265533237; Tue, 20 Mar 2012 10:45:33 -0700 (PDT) Received: by 10.182.47.135 with HTTP; Tue, 20 Mar 2012 10:45:32 -0700 (PDT) In-Reply-To: <201203151417.04507.jhb@freebsd.org> References: <4F5C587B.6010004@gmail.com> <201203151417.04507.jhb@freebsd.org> Date: Tue, 20 Mar 2012 10:45:32 -0700 Message-ID: From: Jason Wolfe To: John Baldwin , Hooman Fazaeli , Adrian Chadd Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-net@freebsd.org Subject: Re: Intel 82574L interface wedging - em7.3.2/8.2-STABLE X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2012 17:45:34 -0000 On Thu, Mar 15, 2012 at 11:17 AM, John Baldwin wrote: > On Sunday, March 11, 2012 3:47:07 am Hooman Fazaeli wrote: >> On 3/11/2012 5:31 AM, Adrian Chadd wrote: >> > Are you able to post the patch here? >> > Maybe Jack can look at what's going on and apply it to the latest >> > intel ethernet driver. >> > >> > >> > Adrian >> > >> >> Below is the patch for if_em.c (7.2.3). It simply checks driver's >> queue status when the link state changes (inactive -> active) and >> start transmit task if queue(s) are not empty. >> >> It also contains stuff I have added to compile on 7 plus some code >> for test and diagnostics. > > Hmm, so I have yet to test this, but I found several bugs related to tran= smit > in em(4) and igb(4) recently just reading the code. =A0(Mostly unnecessar= y > scheduling of tasks for transmit.) =A0I've included your change of restar= ting > TX when link becomes active. =A0I've also updated it to fix resume for em > and igb to DTRT when buf_ring is used, and to not include old-style start > routines at all when using multiq. =A0It is at > http://www.freebsd.org/~jhb/patches/e1000_txeof2.patch > > -- > John Baldwin John/Hooman, Thank for the patch sirs, so far it does look like it did the trick. I'll know for certain here in a few days if I'm still in the clear. I'm guessing after it goes through some more testing it'll be too late to slip it into 8.3? Adrian, Sounds like you might be all set on hardware, but if anything falls through let me know. Jason