From nobody Fri Jan 9 23:47:09 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dnz354L5Xz6MqCr for ; Fri, 09 Jan 2026 23:47:29 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dnz350GBgz40VD for ; Fri, 09 Jan 2026 23:47:28 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-64daeb28c56so7516483a12.2 for ; Fri, 09 Jan 2026 15:47:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768002443; x=1768607243; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tloYfPmLCv705EtH61HN1NuHoyWMUikkXQbeZCZ3r+4=; b=DZZ7FQNvOb92DujjM8uIl4q8VOvjbCXmv7PBDYTGJvzqiEriccS1OIYRinaAHCGKI3 s7VOk0xFswynwK3fPLLx6d34p2FIBNVS5RcgZDFF+PJL5yRmm3+BD2SG+pLb6bqF+GYD S5yLsAMrnL+GEJAk/VKLbjT8hZR1BU+Lq2X16F1DWM5b0BBFhDveVyG5X5/uWdHCyO8Y L+RRTFU2qJo5Vos5uqm6n9K0bEbjjCik7gUdMYj+kljff2mpqGVZBdukCR1IPQ313hR7 0v2wzI/518paPrOKQLEhijzzZq6pOln9tfc4dXJYR7LLom/16x+wlRomcUhOwdznPmc7 T9qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768002443; x=1768607243; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tloYfPmLCv705EtH61HN1NuHoyWMUikkXQbeZCZ3r+4=; b=sgUYeE0KhUs7DY9vlqTDFzNTjpFZwb3LvUrzf78Cyq0RNCEAB1YW9x/xNWIGWDh7ya JylGCjb5Xlsq6jA7OMlXrjWYsNDbXQ3SkuZLSRkpMpDpZm8f37cm+aBTKDDAzFPtqG2p cN1gKr3F9Vc3dyNzw51tOCJTzt86wecze7tGbO0huBbwus4mcAl2/WuYnJL0nLthD76n Vrvp8Ky7iSCXUogYfd/WQLrzCK648Sac463iIFWKEbRjY6GUz3hSQFmsypMoFc9wbVEO YQkbr+T0XH8r9kUTDqzOLgm6pXl9h0ff6Rhee4BizbzJB0UGEXgiJuswt4Iy/85shB1k diXg== X-Forwarded-Encrypted: i=1; AJvYcCVObTdextrU/SfJambx564QmW7sXOc5KuW2dZqtPkzL2IjCxVEwtMwFlkbdO0u+6z0ty2dp3XIroMWbiAWN768li5YH7Q==@freebsd.org X-Gm-Message-State: AOJu0YzSRMacFxYdd3JR35Hj5CaxqmqyuqAPxC4YdIaWaoK9DzRxMoMA DXQ0WuHsyvHpAaOUw9XVZy+VoubBxmLNpIRz1CIumqe4DBYdEl4E7xWPH8N/GCP9exjT1JiveEh Qt6yvC9WjwGVDLPv6J7qng5+eCxepGQ== X-Gm-Gg: AY/fxX4uTD1cNGeFQ1hyeZcgev5/I1XcWUqX65eP9zDZqGUzUSDVIRwilOTkyIYBloR 0+fcwEho0nWE2tar2HmnOdN2xJRbJnB42JWrcqHJTXmT5Ho8mk4+EufLkK+jWtHPeweYwa1Qiq3 ObK0e4IU0LZXIx63Ux2Q4DuvzVNdaAwLUy1zePo01k2kCpuUbTyFUpDXtdvJHVDY7oSyobVBYGy sd27Zk+Eh0a5PvUo/iRJ9btrnVplfDgLzB3i0lajKQmkbR9uxdl7DvgC44Bo9o3kZxDqHt9T6gk TsXInev2rUum90mEVJ4h7je7GQ4i X-Google-Smtp-Source: AGHT+IHLr8hlwHdsX+fH/2evXzfzsrWH7OKbwYbGGCfBKCUAgVI+Ep4Zl97FMGod4Y/FKVjJ7R1LYeqUhQ6+n4m27FY= X-Received: by 2002:a05:6402:4307:b0:640:ff5f:47a8 with SMTP id 4fb4d7f45d1cf-65097decb95mr9663434a12.8.1768002442659; Fri, 09 Jan 2026 15:47:22 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <69604cd7.3aebd.7fdcb739@gitrepo.freebsd.org> In-Reply-To: From: Rick Macklem Date: Fri, 9 Jan 2026 15:47:09 -0800 X-Gm-Features: AZwV_QgSnsuMG5VUYKfVYzPEf5_AXyV03i3Qp55c-2jD3j-2dvYZIfYmbjkDdf4 Message-ID: Subject: Re: git: a6d57f312f18 - main - nfsd: Fix handling of hidden/system during Open/Create To: Benjamin Kaduk Cc: Benjamin Kaduk , Rick Macklem , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dnz350GBgz40VD On Fri, Jan 9, 2026 at 3:42=E2=80=AFPM Benjamin Kaduk wrote= : > > On Fri, Jan 09, 2026 at 03:04:33PM -0800, Rick Macklem wrote: > > On Fri, Jan 9, 2026 at 11:56=E2=80=AFAM Benjamin Kaduk wrote: > > > > > > On Thu, Jan 8, 2026 at 4:33=E2=80=AFPM Rick Macklem wrote: > > >> > > >> The branch main has been updated by rmacklem: > > >> > > >> URL: https://cgit.FreeBSD.org/src/commit/?id=3Da6d57f312f18bbeeda8a3= 4e99d0a662b0db9a190 > > >> > > >> commit a6d57f312f18bbeeda8a34e99d0a662b0db9a190 > > >> Author: Rick Macklem > > >> AuthorDate: 2026-01-08 16:27:32 +0000 > > >> Commit: Rick Macklem > > >> CommitDate: 2026-01-08 16:27:32 +0000 > > >> > > >> nfsd: Fix handling of hidden/system during Open/Create > > >> > > >> When an NFSv4.n client specifies settings for the archive, > > >> hidden and/or system attributes during a Open/Create, the > > >> Open/Create fails for ZFS. This is caused by ZFS doing > > >> a secpolicy_xvattr() call, which fails for non-root. > > >> If this check is bypassed, ZFS panics. > > >> > > >> This patch resolves the problem by disabling va_flags > > >> for the VOP_CREATE() call in the NFSv4.n server and > > >> then setting the flags with a subsequent VOP_SETATTR(). > > >> > > > > > > The diff doesn't really include enough context to tell -- does this i= ntroduce a race window where a file that's supposed to be hidden and/or sys= tem is visible without that attribute from a different process? > > I believe that the answer is no. > > > > VOP_CREATE() returns the new file's vnode exclusively locked > > and the update via VOP_SETATTR() happens before the vnode > > lock is released. > > I expected/hoped that that was the case, but just couldn't tell from the > diff itself. I suppose I should have said that "if there is a race, it is in the FreeBSD OpenZFS port and I would consider that a bug". I am not ZFS guy. rick > > Thanks! > > -Ben