From owner-freebsd-net@FreeBSD.ORG Wed Apr 21 22:39:20 2004 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D897C16A4CE for ; Wed, 21 Apr 2004 22:39:20 -0700 (PDT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id B9EDF43D60 for ; Wed, 21 Apr 2004 22:39:20 -0700 (PDT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (IDENT:brdavis@localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.12.10/8.12.3) with ESMTP id i3M5dIjU020430 for ; Wed, 21 Apr 2004 22:39:18 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.12.10/8.12.3/Submit) id i3M5dIYg020425 for net@freebsd.org; Wed, 21 Apr 2004 22:39:18 -0700 Date: Wed, 21 Apr 2004 22:39:18 -0700 From: Brooks Davis To: net@freebsd.org Message-ID: <20040422053916.GA11221@Odin.AC.HMC.Edu> References: <20040421042453.GA8866@Odin.AC.HMC.Edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs" Content-Disposition: inline In-Reply-To: <20040421042453.GA8866@Odin.AC.HMC.Edu> User-Agent: Mutt/1.5.4i Subject: Re: RFC: if_clone overhaul X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2004 05:39:21 -0000 --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 20, 2004 at 09:24:53PM -0700, Brooks Davis wrote: > Please test/review the following patch to the network interface cloneing > code. This code is a major overhaul of the cloning infrastructure. Repeat after me, always test your "trivial" last minute changes. You need to apply the following patch after applying the previous patch if you want the code to compile. -- Brooks Change 51546 by brooks@brooks_minya on 2004/04/21 22:29:18 Unreorder struct if_clone so initalizer works. Should probably switch to C99 sparc initalizers.. Affected files ... =2E. //depot/user/brooks/xname/sys/net/if_clone.h#11 edit Differences ... =3D=3D=3D=3D //depot/user/brooks/xname/sys/net/if_clone.h#11 (text+ko) =3D= =3D=3D=3D @@ -61,14 +61,15 @@ /* via ifc_(alloc|free)_unit(). */ int ifc_bmlen; /* (c) Bitmap length. */ void *ifc_data; /* (*) Data for ifc_* functions. */ - long ifc_refcnt; /* (i) Refrence count. */ - struct mtx ifc_mtx; /* Muted to protect members. */ =20 /* (c) Driver specific cloning functions. Called with no locks held. */ void (*ifc_attach)(struct if_clone *); int (*ifc_match)(struct if_clone *, const char *); int (*ifc_create)(struct if_clone *, char *, size_t); int (*ifc_destroy)(struct if_clone *, struct ifnet *); + + long ifc_refcnt; /* (i) Refrence count. */ + struct mtx ifc_mtx; /* Muted to protect members. */ }; =20 void if_clone_init(void); --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFAh1pyXY6L6fI4GtQRApczAJ4ye4D1Srdo7YHZBVCLMFSfKhkVyACgmzA4 lwnSU8vee80r4G4cgeeW6zI= =AKIr -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs--