From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Feb 7 16:30:00 2014 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B398FEDD for ; Fri, 7 Feb 2014 16:30:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8DF211FA1 for ; Fri, 7 Feb 2014 16:30:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s17GU0Zw081487 for ; Fri, 7 Feb 2014 16:30:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s17GU0XU081486; Fri, 7 Feb 2014 16:30:00 GMT (envelope-from gnats) Resent-Date: Fri, 7 Feb 2014 16:30:00 GMT Resent-Message-Id: <201402071630.s17GU0XU081486@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Reinier Schoof Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7BBB2801 for ; Fri, 7 Feb 2014 16:20:16 +0000 (UTC) Received: from oldred.freebsd.org (oldred.freebsd.org [IPv6:2001:1900:2254:206a::50:4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 666661DA9 for ; Fri, 7 Feb 2014 16:20:16 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id s17GKF4r011119 for ; Fri, 7 Feb 2014 16:20:15 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id s17GKFAi011112; Fri, 7 Feb 2014 16:20:15 GMT (envelope-from nobody) Message-Id: <201402071620.s17GKFAi011112@oldred.freebsd.org> Date: Fri, 7 Feb 2014 16:20:15 GMT From: Reinier Schoof To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/186536: lang/php5: support for overriding configure flags X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Feb 2014 16:30:00 -0000 >Number: 186536 >Category: ports >Synopsis: lang/php5: support for overriding configure flags >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Feb 07 16:30:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Reinier Schoof >Release: 9.2-RELEASE >Organization: >Environment: FreeBSD x.x.x 9.2-RELEASE FreeBSD 9.2-RELEASE #0 r255898: Thu Sep 26 22:50:31 UTC 2013 root@bake.isc.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64 >Description: I'm using poudriere to create my own packages and I would like to be able to override the default CONFIGURE_ARGS that are given to lang/php5, for instance from my /etc/make.conf like so: .if ${.CURDIR:M*/lang/php5} CONFIGURE_ARGS=--enable-fd-setsize=32768 .endif However, the CONFIGURE_ARGS in /usr/ports/lang/php5/Makefile don't allow to be overridden, unless the attached diff is applied. I don't see any harm in applying my patch, so if you don't either, please do! >How-To-Repeat: Put the following in /etc/make.conf: CONFIGURE_ARGS=--enable-fd-setsize=32768 Build php make -C /usr/ports/lang/php5 and see how the fd-setsize doesn't show up in configure arguments >Fix: Apply this diff to /usr/ports/lang/php5/Makefile: --- Makefile.orig 2014-01-12 14:36:37.978364561 +0100 +++ Makefile 2014-01-12 14:31:57.075042793 +0100 @@ -23,7 +23,7 @@ LIB_DEPENDS= libpcre.so:${PORTSDIR}/devel/pcre -CONFIGURE_ARGS= \ +CONFIGURE_ARGS+= \ --with-layout=GNU \ --localstatedir=/var \ --with-config-file-scan-dir=${PREFIX}/etc/php \ >Release-Note: >Audit-Trail: >Unformatted: