From owner-svn-ports-head@freebsd.org  Thu Nov 12 03:05:38 2015
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 81ABBA2D0DE;
 Thu, 12 Nov 2015 03:05:38 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 745C21A38;
 Thu, 12 Nov 2015 03:05:38 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 7364D1E78; Thu, 12 Nov 2015 03:05:38 +0000 (UTC)
Date: Thu, 12 Nov 2015 03:05:38 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Bryan Drewery <bdrewery@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r401299 - head/security/openssh-portable/files
Message-ID: <20151112030538.GA71430@FreeBSD.org>
References: <201511112121.tABLLjO6051679@repo.freebsd.org>
 <20151112021225.GB43902@FreeBSD.org> <5643FC04.4020001@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5643FC04.4020001@FreeBSD.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Nov 2015 03:05:38 -0000

On Wed, Nov 11, 2015 at 06:40:04PM -0800, Bryan Drewery wrote:
> On 11/11/15 6:12 PM, Alexey Dokuchaev wrote:
> > On Wed, Nov 11, 2015 at 09:21:45PM +0000, Bryan Drewery wrote:
> >> New Revision: 401299
> >> URL: https://svnweb.freebsd.org/changeset/ports/401299
> >>
> >> Log:
> >>   Make portlint stop spamming me.  It's gotten quite silly.
> > 
> > [...]
> > As John had said on IRC, this helps to get consistent patches, because
> > prople rarely think about these little details ("repo churn? who cares
> > about it") and portlint(1) warning gives them simple and straight course
> > of action.  Yet it's true that the check could probably be made somewhat
> > smarter than simple grepping for "UTC".
> > 
> > TL;DR: instead of adding noise to the patches, it's better to improve
> > portlint(1).  Or learn how to ignore its warnings. ;-)
> 
> We should just ignore portlint at our own discretion since it grows
> stupid warnings like this?

Ignoring stupid warnings was listed second after improving portlint(1).
But yes, portlint(1) can be wrong, so, answering your question, yes, "we
should just ignore portlint at our own discretion".  Every software has
bugs, checkers can give false positives.

> Mission accomplished?

Mission is not to follow *everything* any lint tool tells you about your
code and stuff.  The mission is to have that stuff working and neat, with
some tools' help or without.

That's why I think that adding noise to patches is wrong approach: it makes
the stuff (patches) less neat and thus portlint(1) warnings more important,
while it should be the other way around.

./danfe