From owner-cvs-all Sun Mar 17 13:21:32 2002 Delivered-To: cvs-all@freebsd.org Received: from rwcrmhc51.attbi.com (rwcrmhc51.attbi.com [204.127.198.38]) by hub.freebsd.org (Postfix) with ESMTP id 5B89037B402; Sun, 17 Mar 2002 13:21:22 -0800 (PST) Received: from 12-234-22-238.client.attbi.com ([12.234.22.238]) by rwcrmhc51.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020317212119.NNYQ2626.rwcrmhc51.attbi.com@12-234-22-238.client.attbi.com>; Sun, 17 Mar 2002 21:21:19 +0000 Received: from master.gorean.org (master.gorean.org [10.0.0.2]) by 12-234-22-238.client.attbi.com (8.11.6/8.11.6) with ESMTP id g2HLLIh55319; Sun, 17 Mar 2002 13:21:18 -0800 (PST) (envelope-from DougB@FreeBSD.org) Received: from master.gorean.org (localhost [127.0.0.1]) by master.gorean.org (8.12.2/8.12.2) with ESMTP id g2HLLI3s006014; Sun, 17 Mar 2002 13:21:18 -0800 (PST) (envelope-from DougB@FreeBSD.org) Received: from localhost (doug@localhost) by master.gorean.org (8.12.2/8.12.2/Submit) with ESMTP id g2HLLI9X006011; Sun, 17 Mar 2002 13:21:18 -0800 (PST) X-Authentication-Warning: master.gorean.org: doug owned process doing -bs Date: Sun, 17 Mar 2002 13:21:18 -0800 (PST) From: Doug Barton X-X-Sender: doug@master.gorean.org To: Akinori MUSHA Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: ports/net/bind9 Makefile distinfo pkg-plist In-Reply-To: <861yeiq4nj.wl@archon.local.idaemons.org> Message-ID: <20020317131650.C3758-100000@master.gorean.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 18 Mar 2002, Akinori MUSHA wrote: > At Sun, 17 Mar 2002 12:49:37 -0800 (PST), > Doug Barton wrote: > > On Mon, 18 Mar 2002, Akinori MUSHA wrote: > > > > > At Sun, 17 Mar 2002 11:11:05 -0800 (PST), > > > Doug Barton wrote: > > > > Thank you for your suggestion. I used a simplified version of it > > > > > > It's okay but it looks somewhat redundant to put the version number > > > three times in Makefile, > > > > I count two. PORTVERSION and ISCVERSION. Can you show me the > > third? > > It's in DISTFILES. You can use ${ISCVERSION} in it. > > DISTFILES= bind-9.2.1rc1.tar.gz Ah, thanks.... as soon as the ISC releases a RELEASE version, all of that silliness goes away, so I didn't think it was worth it.... I will keep that suggestion in mind though, thanks. > > > and you could remove a redundant '/' in the > > > ${MASTER_SITE_RINGSERVER:...} line. > > > > I'm not sure what you mean by that. > > ${MASTER_SITE_RINGSERVER:S,%SUBDIR%,net/bind9/${ISCVERSION}/,} > ~ > > This trailing '/' is redundant. Oh... well, that ring server stuff was added by someone else, so if they're watching...... > > > +LATEST_LINK= bind9 > > > > I didn't miss it, frankly I'm not sure what it does. However, > > by changing PORTNAME I'm sure that 'pkg_add bind' and 'pkg_add bind9' do > > exactly what I want them to. > > It's fine. I just showed another solution in case you were thinking > changing PORTNAME was an unwanted workaround. Ah, ok. That's what I thought, but thank you for clarifying. > OK... I'm sorry if I sounded pushing. Next time I'll just simply > inform you of a problem instead of issuing a verbose patch. You didn't. I just get frustrated sometimes with 12 different people offering me 14 different solutions. -- "We have known freedom's price. We have shown freedom's power. And in this great conflict, ... we will see freedom's victory." - George W. Bush, President of the United States State of the Union, January 28, 2002 Do YOU Yahoo!? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message