Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 17 Mar 2002 13:21:18 -0800 (PST)
From:      Doug Barton <DougB@FreeBSD.org>
To:        Akinori MUSHA <knu@iDaemons.org>
Cc:        cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org>
Subject:   Re: cvs commit: ports/net/bind9 Makefile distinfo pkg-plist
Message-ID:  <20020317131650.C3758-100000@master.gorean.org>
In-Reply-To: <861yeiq4nj.wl@archon.local.idaemons.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 18 Mar 2002, Akinori MUSHA wrote:

> At Sun, 17 Mar 2002 12:49:37 -0800 (PST),
> Doug Barton wrote:
> > On Mon, 18 Mar 2002, Akinori MUSHA wrote:
> >
> > > At Sun, 17 Mar 2002 11:11:05 -0800 (PST),
> > > Doug Barton wrote:
> > > > 	Thank you for your suggestion. I used a simplified version of it
> > >
> > > It's okay but it looks somewhat redundant to put the version number
> > > three times in Makefile,
> >
> > 	I count two. PORTVERSION and ISCVERSION. Can you show me the
> > third?
>
> It's in DISTFILES.  You can use ${ISCVERSION} in it.
>
> DISTFILES=	bind-9.2.1rc1.tar.gz

Ah, thanks.... as soon as the ISC releases a RELEASE version, all of that
silliness goes away, so I didn't think it was worth it.... I will keep
that suggestion in mind though, thanks.

> > > and you could remove a redundant '/' in the
> > > ${MASTER_SITE_RINGSERVER:...} line.
> >
> > 	I'm not sure what you mean by that.
>
> 		${MASTER_SITE_RINGSERVER:S,%SUBDIR%,net/bind9/${ISCVERSION}/,}
> 		                                                           ~
>
> This trailing '/' is redundant.

	Oh... well, that ring server stuff was added by someone else, so
if they're watching......

> > > +LATEST_LINK=	bind9
> >
> > 	I didn't miss it, frankly I'm not sure what it does. However,
> > by changing PORTNAME I'm sure that 'pkg_add bind' and 'pkg_add bind9' do
> > exactly what I want them to.
>
> It's fine.  I just showed another solution in case you were thinking
> changing PORTNAME was an unwanted workaround.

	Ah, ok. That's what I thought, but thank you for clarifying.

> OK...  I'm sorry if I sounded pushing.  Next time I'll just simply
> inform you of a problem instead of issuing a verbose patch.

	You didn't. I just get frustrated sometimes with 12 different
people offering me 14 different solutions.


-- 
   "We have known freedom's price. We have shown freedom's power.
      And in this great conflict, ...  we will see freedom's victory."
	- George W. Bush, President of the United States
          State of the Union, January 28, 2002

         Do YOU Yahoo!?



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020317131650.C3758-100000>