From owner-svn-src-head@freebsd.org  Fri Nov 13 21:42:15 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 30C5FA2E385;
 Fri, 13 Nov 2015 21:42:15 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id AEB7811C8;
 Fri, 13 Nov 2015 21:42:14 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.15.2/8.15.2) with ESMTPS id tADLg4EV073147
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Sat, 14 Nov 2015 00:42:04 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.15.2/8.15.2/Submit) id tADLg4gc073146;
 Sat, 14 Nov 2015 00:42:04 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Sat, 14 Nov 2015 00:42:04 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Steven Hartland <smh@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r290403 - head/sys/netinet
Message-ID: <20151113214204.GA73031@FreeBSD.org>
References: <201511051723.tA5HN24j065530@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201511051723.tA5HN24j065530@repo.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Nov 2015 21:42:15 -0000

  Steven,

On Thu, Nov 05, 2015 at 05:23:02PM +0000, Steven Hartland wrote:
S> Author: smh
S> Date: Thu Nov  5 17:23:02 2015
S> New Revision: 290403
S> URL: https://svnweb.freebsd.org/changeset/base/290403
S> 
S> Log:
S>   Add MTU support to carp interfaces
S>   
S>   MFC after:	2 weeks
S>   Sponsored by:	Multiplay

What is "carp interfaces"? I believe you are committing a patch to FreeBSD 9
into FreeBSD 11, w/o doing any testing and w/o doing even light review of
surrounding code, which differes a lot from FreeBSD 9.

Please back this out or correct me being wrong.

S> Modified:
S>   head/sys/netinet/ip_carp.c
S> 
S> Modified: head/sys/netinet/ip_carp.c
S> ==============================================================================
S> --- head/sys/netinet/ip_carp.c	Thu Nov  5 17:19:08 2015	(r290402)
S> +++ head/sys/netinet/ip_carp.c	Thu Nov  5 17:23:02 2015	(r290403)
S> @@ -1769,6 +1769,13 @@ carp_ioctl(struct ifreq *ifr, u_long cmd
S>  		}
S>  		break;
S>  	    }
S> +	case SIOCSIFMTU:
S> +		if (ifr->ifr_mtu > ETHERMTU_JUMBO) {
S> +			error = EINVAL;
S> +		} else {
S> +			ifp->if_mtu = ifr->ifr_mtu;
S> +		}
S> +		break;
S>  	default:
S>  		error = EINVAL;
S>  	}
S> _______________________________________________
S> svn-src-all@freebsd.org mailing list
S> https://lists.freebsd.org/mailman/listinfo/svn-src-all
S> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"

-- 
Totus tuus, Glebius.