From owner-svn-ports-head@freebsd.org Wed May 22 13:04:28 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ED8DB15ABB92; Wed, 22 May 2019 13:04:27 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 61D0684BBF; Wed, 22 May 2019 13:04:27 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pl1-x62e.google.com with SMTP id p15so1058641pll.4; Wed, 22 May 2019 06:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KzkfS/PjHYmREnoGQsoWtwVInzpwI34prD7Agj7/5Tg=; b=UyCVEHF+xjTLCpq4n+7tUbmocR5fT9UHoKRWZj7jbUUft/c6UF9ncwaOoBGv7Ccs3+ BcQSrnrM6SioFGGLOX9aMjzRG3oa3ww9so9th7U9ogRT/xPXPKqNwpOWXek4C7FR02mt kV4W13uXGtZv9XfkNm48OLVGDqnOXX2zzofdZ288kWPKWNcOgmzWYZFb/nST34qqvzyF ngHcXbJzqQ3iZfelWf8yGZVt/Gkaz60tWdivBAhbT6PMjC+oCk9gJmYXFuiPdiVIIbSR lhwXK8Rncw7YynvwNEVyO4QjAfZ0hRE+1KHEMggNU9pSZ76mJ3ezMKdi0lGNOTYZtIqr GuJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=KzkfS/PjHYmREnoGQsoWtwVInzpwI34prD7Agj7/5Tg=; b=XZJNYYADgWtLe5D2hMfErhRpkg3tEQEzgBkeV9TfRKzfJdJ1Pg4VQk99LB7L2DrbAM 82D8IhyqmQu0xtmCPl3Pdo1EzouHF8xsvS6wAWWGEJckmvvD6QaJau6tF9V2xZZHUBgk EZT7AaiPYhnyu2ie3k06XgGaeo5xvk5P/I0Ouez7odp8s2ZR4IdqSLknAWJPtK5Dfgol F/BwDqfGP3n+O4iOsGoE/j4B4O2bNrcCYvs0DQiDYU5uUUM0lYDHv3nA03hfY4U2AXL+ P+5NuzqDuJmqGp96NVPIf16Iiycz5a9qREcG4fmt3tWdFPenogwXP5hjtdq7lNRi++gs 8QHA== X-Gm-Message-State: APjAAAWfIUPUtmSrEzVdW+qPtuicsoS8xNEgfBD4JvgjtG7FI5ucq5d6 WEc4cm5uJb2GxGWKsnBAoRzulwkK X-Google-Smtp-Source: APXvYqxv1G6W/m0BVSB9obP4cryPFPzerMflU8j/tKCNpJ4AB8IKodPIs4s1L0o1Tkfoy9Lt+adKwg== X-Received: by 2002:a17:902:7883:: with SMTP id q3mr16150222pll.89.1558530265995; Wed, 22 May 2019 06:04:25 -0700 (PDT) Received: from [192.168.1.105] (121-200-20-216.79c814.syd.nbn.aussiebb.net. [121.200.20.216]) by smtp.gmail.com with ESMTPSA id u38sm67079258pgn.73.2019.05.22.06.04.23 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 22 May 2019 06:04:25 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r502238 - in head/x11: . py-pyscreenshot To: Steve Wills Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201905220108.x4M18hFR056638@repo.freebsd.org> <20190522070947.GA31138@FreeBSD.org> <95155332-148d-38f0-7fee-f07e931c1682@FreeBSD.org> From: Kubilay Kocak Message-ID: Date: Wed, 22 May 2019 23:04:21 +1000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Thunderbird/67.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 61D0684BBF X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.972,0]; TAGGED_FROM(0.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 May 2019 13:04:28 -0000 On 22/05/2019 10:07 pm, Steve Wills wrote: > Hi, > > On 5/22/19 3:16 AM, Kubilay Kocak wrote: >> pyscreenshots setup.py doesn't reference pillow, but a dependent port > > pyscreenshot/plugins/wxscreen.py looks like it does: > > from PIL import Image > > which I think comes from graphics/py-pillow. Am I missing something? In that case nope, upstream should list pillow in install_requires, unless its optional, in which case extras_require >> for which this was added (pyvirtualdisplay) does. I'm guessing it was >> inadvertent. >> >> I've already send Steve an email mentioning it > > This is the only email I saw. > >> Either way, not adding a port because the pkg-descr was wrong (I dont >> think it is however, given it doesn't depend on pillow) is a bit much. >> >> We'd just amend the pkg-descr not to make the claim thereby restoring >> balance to your force > > Any suggestions on what pkg-descr should say? Probably something like from upstreams setup.pylong_description (README): The pyscreenshot module can be used to copy the contents of the screen to a PIL_ or Pillow_ image memory using various back-ends. Features: * Cross-platform wrapper * Capturing the whole desktop * Capturing an area * saving to PIL_ or Pillow_ image memory > Steve