From owner-svn-src-all@freebsd.org Tue Apr 30 13:10:12 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 30B3615909A4; Tue, 30 Apr 2019 13:10:12 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [176.58.89.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C199F6F937; Tue, 30 Apr 2019 13:10:11 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 44thhf1CXZzDjs5; Tue, 30 Apr 2019 13:10:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([127.0.0.1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [127.0.0.1]) (amavisd-new, port 10587) with ESMTPS id zjJolTN-WpJO; Tue, 30 Apr 2019 13:10:09 +0000 (UTC) Received: from garnet.daemonic.se (host-95-192-79-116.mobileonline.telia.com [95.192.79.116]) by mail.daemonic.se (Postfix) with ESMTPSA id 44thhd33m2zDjp8; Tue, 30 Apr 2019 13:10:09 +0000 (UTC) Subject: Re: svn commit: r346958 - head/sys/compat/linuxkpi/common/src To: Hans Petter Selasky , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201904301041.x3UAfLvj054368@repo.freebsd.org> From: Niclas Zeising Message-ID: <8f360678-2df1-fe7b-cb83-f47923534826@freebsd.org> Date: Tue, 30 Apr 2019 15:10:08 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <201904301041.x3UAfLvj054368@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C199F6F937 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.980,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Apr 2019 13:10:12 -0000 On 2019-04-30 12:41, Hans Petter Selasky wrote: > Author: hselasky > Date: Tue Apr 30 10:41:20 2019 > New Revision: 346958 > URL: https://svnweb.freebsd.org/changeset/base/346958 > > Log: > Reduce the number of mutexes after r346645 in the LinuxKPI. > Make function macro wrappers for locking and unlocking to ease readability. > > No functional change. > > Discussed with: kib@, tychon@ and zeising@ I was not part of any discussion regarding this. If this is related to https://reviews.freebsd.org/D20097 I explicitly asked you on gitter to hold of for a bit, while we try to figure out why we are seeing regressions in graphics with the latest dmar changes. Can you please revert this since it colludes the dmar graphics issue, and it makes the suggested patch not apply cleanly, which makes it harder to get people to help test. Thank you! Regards -- Niclas Zeising