From owner-svn-src-all@FreeBSD.ORG  Fri Jan  9 17:56:53 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B0173106566B;
	Fri,  9 Jan 2009 17:56:53 +0000 (UTC)
	(envelope-from prvs=julian=25380973a@elischer.org)
Received: from smtp-outbound.ironport.com (smtp-outbound.ironport.com
	[63.251.108.112])
	by mx1.freebsd.org (Postfix) with ESMTP id 93B8E8FC12;
	Fri,  9 Jan 2009 17:56:53 +0000 (UTC)
	(envelope-from prvs=julian=25380973a@elischer.org)
Received: from unknown (HELO julian-mac.elischer.org) ([10.251.60.87])
	by smtp-outbound.ironport.com with ESMTP; 09 Jan 2009 09:47:27 -0800
Message-ID: <49678DAE.5000903@elischer.org>
Date: Fri, 09 Jan 2009 09:47:26 -0800
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.19 (Macintosh/20081209)
MIME-Version: 1.0
To: Adrian Chadd <adrian@FreeBSD.org>
References: <200901091716.n09HGIYN062768@svn.freebsd.org>
In-Reply-To: <200901091716.n09HGIYN062768@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r186959 - head/sys/netinet
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Jan 2009 17:56:54 -0000

Adrian Chadd wrote:
> Author: adrian
> Date: Fri Jan  9 17:16:18 2009
> New Revision: 186959
> URL: http://svn.freebsd.org/changeset/base/186959
> 
> Log:
>   Comment some potentially confusing logic.
>   
>   Nitpicking by: mlaier
>   
>   MFC after:	2 weeks
> 
> Modified:
>   head/sys/netinet/in_pcb.c
> 
> Modified: head/sys/netinet/in_pcb.c
> ==============================================================================
> --- head/sys/netinet/in_pcb.c	Fri Jan  9 16:37:29 2009	(r186958)
> +++ head/sys/netinet/in_pcb.c	Fri Jan  9 17:16:18 2009	(r186959)
> @@ -347,6 +347,11 @@ in_pcbbind_setup(struct inpcb *inp, stru
>  		} else if (sin->sin_addr.s_addr != INADDR_ANY) {
>  			sin->sin_port = 0;		/* yech... */
>  			bzero(&sin->sin_zero, sizeof(sin->sin_zero));
> +			/*
> +			 * Is the address a local IP address? 
> +			 * If INP_NONLOCALOK is set, then the socket may be bound
> +			 * to any local endpoint address.
                                   ^ NON



or "any address, local or not"

> +			 */
>  			if (
>  #if defined(IP_NONLOCALBIND)
>  			    ((inp->inp_flags & INP_NONLOCALOK) == 0) &&