Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 24 Apr 2003 20:40:39 +1000
From:      Tim Robbins <tjr@FreeBSD.ORG>
To:        freebsd-fs@freebsd.org
Subject:   quot(8) on UFS2
Message-ID:  <20030424204039.A66020@dilbert.robbins.dropbear.id.au>

next in thread | raw e-mail | index | archive | help
Someone mentioned on one of the lists that the quot(8) utility doesn't work
properly on UFS2 filesystems. I think this is because the fs_sblockloc test in
quot() is incorrect. Are there any objections to this patch? I'd like to
commit it before 5.1 is released because UFS2 has been made the default FS.

--- //depot/user/tjr/freebsd-tjr/src/usr.sbin/quot/quot.c	2003/04/21 22:23:11
+++ //depot/user/tjr/freebsd-tjr/src/usr.sbin/quot/quot.c	2003/04/24 03:34:52
@@ -563,7 +563,7 @@
 		fs = (struct fs *)superblock;
 		if ((fs->fs_magic == FS_UFS1_MAGIC ||
 		     (fs->fs_magic == FS_UFS2_MAGIC &&
-		      fs->fs_sblockloc == numfrags(fs, sblock_try[i]))) &&
+		      fs->fs_sblockloc == sblock_try[i])) &&
 		    fs->fs_bsize <= MAXBSIZE &&
 		    fs->fs_bsize >= sizeof(struct fs))
 			break;



Tim



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030424204039.A66020>