From owner-freebsd-current@FreeBSD.ORG  Tue Jun 26 17:23:13 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id C50A1106566B
	for <freebsd-current@FreeBSD.org>; Tue, 26 Jun 2012 17:23:13 +0000 (UTC)
	(envelope-from mp@FreeBSD.org)
Received: from relay03.pair.com (relay03.pair.com [209.68.5.17])
	by mx1.freebsd.org (Postfix) with SMTP id 639128FC14
	for <freebsd-current@FreeBSD.org>; Tue, 26 Jun 2012 17:23:13 +0000 (UTC)
Received: (qmail 26638 invoked by uid 0); 26 Jun 2012 17:23:06 -0000
Received: from 173.37.0.44 (HELO ?173.37.0.44?) (173.37.0.44)
	by relay03.pair.com with SMTP; 26 Jun 2012 17:23:06 -0000
X-pair-Authenticated: 173.37.0.44
Message-ID: <4FE9EFF9.9080507@FreeBSD.org>
Date: Tue, 26 Jun 2012 10:23:05 -0700
From: Mark Peek <mp@FreeBSD.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
	rv:13.0) Gecko/20120614 Thunderbird/13.0.1
MIME-Version: 1.0
To: pfg@freebsd.org
References: <1340474946.11584.YahooMailClassic@web113506.mail.gq1.yahoo.com>
In-Reply-To: <1340474946.11584.YahooMailClassic@web113506.mail.gq1.yahoo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-current@FreeBSD.org
Subject: Re: [RFT] llquantize for FreeBSD's dtrace
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jun 2012 17:23:13 -0000

On 6/23/12 11:09 AM, Pedro Giffuni wrote:
>
>
> --- Sab 23/6/12, Fabian Keil <freebsd-listen@fabiankeil.de> ha scritto:
> ...
>>> My suggestion would be to instead try using the test
>>> scripts in
>>>
>> cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantize/
>>>
>>> err.D_LLQUANT_FACTORSMALL.d (for example) has
>>>
>>> @ = llquantize(0, 1, 0, 10, 10);
>>
>> The problem appears to be unrelated to the syntax change:
>>
>> fk@r500
>> /usr/src/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantize
>> $sudo dtrace -s err.D_LLQUANT_FACTORSMALL.d
>> Assertion failed: (!(arg & (UINT16_MAX <<
>> args[i].shift))), file
>>
>
> It's a different assertion.
>
> Probably some difference between Solaris and BSD.
> this is very useful, thanks!

Try this, change the assert on line 1429 in file dt_cc.c from:

assert(!(arg & (UINT16_MAX << args[i].shift)));

to

assert(!(arg & ((uint64_t)UINT16_MAX << args[i].shift)));


Mark