From owner-cvs-all Thu Sep 6 20: 1: 1 2001 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 29A7737B401; Thu, 6 Sep 2001 20:00:52 -0700 (PDT) Received: (from ache@localhost) by nagual.pp.ru (8.11.6/8.11.6) id f8730lD95945; Fri, 7 Sep 2001 07:00:48 +0400 (MSD) (envelope-from ache) Date: Fri, 7 Sep 2001 07:00:46 +0400 From: "Andrey A. Chernov" To: Alfred Perlstein Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdio stdio.c Message-ID: <20010907070046.A95860@nagual.pp.ru> References: <200109070213.f872DCa19917@freefall.freebsd.org> <20010906212527.W81307@elvis.mu.org> <20010907063714.B95517@nagual.pp.ru> <20010906215518.X81307@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20010906215518.X81307@elvis.mu.org> User-Agent: Mutt/1.3.21i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Sep 06, 2001 at 21:55:18 -0500, Alfred Perlstein wrote: > * Andrey A. Chernov [010906 21:37] wrote: > > On Thu, Sep 06, 2001 at 21:25:27 -0500, Alfred Perlstein wrote: > > > change you did broke things. One way to fix this would be to record > > > the failed lseek returning EISPIPE and noting that the backing > > > object is not seekable, from then on you could avoid the unnescesary > > > syscalls. > > > > I plan to do exact the same thing you describe (i.e. remove __SAPP when > > ESPIPE happens) + add error checking for __SOPT (i.e. regular) files only. > > I'm not sure that's completely safe, a user defined stdio stream > may switch the underlying file, it we cache information we may > break the ability to do that. __SAPP is set only in one place (for fdopen()'ed files) and never for user-defined streams. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message