From owner-cvs-all Sat May 19 23:24:33 2001 Delivered-To: cvs-all@freebsd.org Received: from obsecurity.dyndns.org (adsl-63-207-60-32.dsl.lsan03.pacbell.net [63.207.60.32]) by hub.freebsd.org (Postfix) with ESMTP id 50B3637B422; Sat, 19 May 2001 23:24:26 -0700 (PDT) (envelope-from kris@obsecurity.org) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id BBA0B66E20; Sat, 19 May 2001 23:24:25 -0700 (PDT) Date: Sat, 19 May 2001 23:24:25 -0700 From: Kris Kennaway To: Bruce Evans Cc: Kris Kennaway , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.sys.mk Makefile bsd.kmod.mk bsd.lib.mk bsd.prog.mk Message-ID: <20010519232425.A20670@xor.obsecurity.org> References: <200105192318.f4JNIMp86494@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="u3/rZRmxL6MmkK24" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from bde@zeta.org.au on Sun, May 20, 2001 at 03:54:17PM +1000 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --u3/rZRmxL6MmkK24 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 20, 2001 at 03:54:17PM +1000, Bruce Evans wrote: > On Sat, 19 May 2001, Kris Kennaway wrote: >=20 > > kris 2001/05/19 16:18:21 PDT > >=20 > > Modified files: > > share/mk Makefile bsd.kmod.mk bsd.lib.mk=20 > > bsd.prog.mk=20 > > Added files: > > share/mk bsd.sys.mk=20 > > Log: > > Bring in the WARNS directive from NetBSD, localized in a new bsd.sys.= mk > > to avoid polluting sys.mk. This directive controls the addition of > > compiler warning flags to CFLAGS in a relatively compiler-neutral man= ner. > > =20 > > The idea is that WARNS can be set in Makefile.inc or in individual > > Makefiles as they become clean, to prevent the introduction of new > > warnings in the code. -Werror is added by default >=20 > Please don't clutter individual Makefiles with it. >=20 > I think it would be more useful to fix all the bugs reported with the > standard warning flags (-Wall for src/bin, lots for kernels, but none > for everything else) first. The output from `make -ss' should be null, > but is currently almost 100K. -Wall in individual Makefiles has had > a negative effect in preventing new warnings (it causes so many warnings > that people ignore them all). I'm only adding WARNS once I've fixed all warnings on alpha and i386. Since it has the effect of adding -Werror, it's kind of hard for people to ignore it when they introduce a new one :-) For people doing a new architecture port or playing with weird compilation options, NO_WERROR or NO_WARNS is available. Once we get all (or most) of the subdirectories building with WARNS, we can shift it to ../Makefile.inc and set WARNS=3D0 on the remainder. Kris --u3/rZRmxL6MmkK24 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.5 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE7B2MZWry0BWjoQKURAiSfAJ41mHWZfjdzQmpRAsCAWq5GxB7iDQCfatDi PQTpSmT+VN57huqgM4Zid1Q= =A6JB -----END PGP SIGNATURE----- --u3/rZRmxL6MmkK24-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message