From owner-cvs-sys  Thu May 21 11:26:00 1998
Return-Path: <owner-cvs-sys>
Received: (from daemon@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id LAA27311
          for cvs-sys-outgoing; Thu, 21 May 1998 11:26:00 -0700 (PDT)
          (envelope-from owner-cvs-sys)
Received: from ns1.yes.no (ns1.yes.no [195.119.24.10])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA27270;
          Thu, 21 May 1998 11:25:43 -0700 (PDT)
          (envelope-from eivind@bitbox.follo.net)
Received: from bitbox.follo.net (bitbox.follo.net [195.204.143.218])
	by ns1.yes.no (8.8.7/8.8.7) with ESMTP id SAA10561;
	Thu, 21 May 1998 18:25:42 GMT
Received: (from eivind@localhost)
	by bitbox.follo.net (8.8.8/8.8.6) id UAA01579;
	Thu, 21 May 1998 20:25:42 +0200 (MET DST)
Message-ID: <19980521202541.60347@follo.net>
Date: Thu, 21 May 1998 20:25:41 +0200
From: Eivind Eklund <eivind@yes.no>
To: "Jordan K. Hubbard" <jkh@time.cdrom.com>,
        "Justin T. Gibbs" <gibbs@plutotech.com>
Cc: "Jordan K. Hubbard" <jkh@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG,
        cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/pci if_tl.c if_tlreg.h
References: <199805211641.KAA15418@pluto.plutotech.com> <27038.895770770@time.cdrom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.89.1i
In-Reply-To: <27038.895770770@time.cdrom.com>; from Jordan K. Hubbard on Thu, May 21, 1998 at 10:12:50AM -0700
Sender: owner-cvs-sys@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

On Thu, May 21, 1998 at 10:12:50AM -0700, Jordan K. Hubbard wrote:
> > No, no, no.  Create an osreldate.h file instead.  Please?  Using __FreeBSD__
> > doesn't work because it's tied to the compiler, not the source.
> 
> 1. The osreldate.h file just isn't created in time and if we want
>    our SNAP builds to work for now, this change has to happen.
>    If we want to work out how to get the osreldate.h file bootstrapped
>    into place at a later time then that's fine with me, but there's
>    no use holding up the show until then.

That was the change I installed and backed out so fast earlier today;
it unfortunately didn't work.

> 2. Absolutely *nothing* else in the system that I've been able to
>    find uses __FreeBSD_version directly in the way that this driver
>    did.  If this is really a step forward then I'd suggest that
>    a whole lot more needs changing if self-consistency is also your
>    goal (and I think it should be, especially where this kind of
>    stuff is concerned, since other driver writers will imitate it).

The reason nothing else use __FreeBSD_version directly in this way is
that we don't provide it to kernel files, and that _suck_.  It is one
of the biggest hurdles for people attempting to do development outside
of the FreeBSD tree proper.

Eivind.