From owner-cvs-all  Wed Sep 18  7:31:54 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8B77B37B401; Wed, 18 Sep 2002 07:31:52 -0700 (PDT)
Received: from bast.unixathome.org (bast.unixathome.org [216.187.105.150])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E8C5043E42; Wed, 18 Sep 2002 07:31:51 -0700 (PDT)
	(envelope-from dan@langille.org)
Received: from wocker (wocker.unixathome.org [192.168.0.99])
	by bast.unixathome.org (Postfix) with ESMTP
	id 2D4933F28; Wed, 18 Sep 2002 10:31:51 -0400 (EDT)
From: "Dan Langille" <dan@langille.org>
To: Dominic Marks <dominic_marks@btinternet.com>
Date: Wed, 18 Sep 2002 10:32:37 -0400
MIME-Version: 1.0
Subject: Re: cvs commit: ports/devel/gindent Makefile pkg-plist ports/devel/gindent/files patch-doc:Makefile.in
Cc: Peter Pentchev <roam@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Message-ID: <3D885645.23711.41D1B0FD@localhost>
In-reply-to: <20020918142950.GA34573@gallium>
References: <3D88438C.16000.41888E90@localhost>
X-mailer: Pegasus Mail for Windows (v4.02)
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7BIT
Content-description: Mail message body
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On 18 Sep 2002 at 15:29, Dominic Marks wrote:

> On Wed, Sep 18, 2002 at 09:12:44AM -0400, Dan Langille wrote:
> > On 18 Sep 2002 at 5:32, Peter Pentchev wrote:
> > 
> > > roam        2002/09/18 05:32:37 PDT
> > > 
> > >   Modified files:
> > >     devel/gindent        Makefile pkg-plist 
> > >     devel/gindent/files  patch-doc:Makefile.in 
> > >   Log:
> > >   Support CFLAGS/CXXFLAGS properly.
> > >   Honor NOPORTDOCS.
> > 
> > Waking up this morning, FreshPorts tells me[1] there is a problem
> > with this port:
> > 
> > [dan@undef:~/ports/devel/gindent] $ make -V PORTVERSION
> > "/usr/home/dan/ports/devel/gindent/Makefile", line 36: Malformed
> > conditional (!defiend(NOPORTDOCS))
> > "/usr/home/dan/ports/devel/gindent/Makefile", line 40: if-less endif
> > "/usr/home/dan/ports/devel/gindent/Makefile", line 40: Need an
> > operator make: fatal errors encountered -- cannot continue
> > [dan@undef:~/ports/devel/gindent] $
> > 
> > Here's the patch:
> > 
> > -.if !defiend(NOPORTDOCS)
> > +.if !defined(NOPORTDOCS)
> > 
> > [1] - FreshPorts would have told roam if he was opt'd in at 
> > FreshPorts.  FreshPorts runs a sanity test on every port commit.  If
> > a commiter opts in, any errors found in their commits are reported
> > directly to them instead of me being the go between.  I urge every
> > port committer to opt in.  It saves me the bother of reporting your
> > errors to you and the world.  It also means the problem is fixed
> > much sooner.  At present, we have 15 opt'd in committers, where are
> > the rest of you?
> 
> It would be nice of non-committer maintainers could also receive these
> warnings, any reason why this a committer only thing ?

Please join the conversation in -ports.  We covered that one.  See 
Subject: HEADS UP: all ports committers urged to opt in".
-- 
Dan Langille
I'm looking for a computer job:
http://www.freebsddiary.org/dan_langille.php


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message