From owner-svn-src-all@FreeBSD.ORG Fri May 18 06:30:36 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5F777106566B; Fri, 18 May 2012 06:30:36 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mexforwardwc.lss.emc.com (mexforwardwc.lss.emc.com [137.69.117.200]) by mx1.freebsd.org (Postfix) with ESMTP id 35E678FC08; Fri, 18 May 2012 06:30:36 +0000 (UTC) Received: from scl02-01d02-si01.isus.emc.com (scl02-01d02-si01.isus.emc.com [137.69.225.84]) by mexforwardwc.lss.emc.com (Switch-3.4.3/Switch-3.4.3) with ESMTP id q4I6UUPM024167 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 17 May 2012 23:30:30 -0700 Received: from mailhubwc.lss.emc.com (mailhubscprd03.lss.emc.com [137.69.224.145]) by scl02-01d02-si01.isus.emc.com (RSA Interceptor); Thu, 17 May 2012 23:30:17 -0700 Received: from seacasht02.desktop.isilon.com (seacasht02.isilon.com [137.69.159.81]) by mailhubwc.lss.emc.com (Switch-3.4.3/Switch-3.4.3) with ESMTP id q4I6UHUt021306; Thu, 17 May 2012 23:30:17 -0700 Received: from seaxch12.isilon.com (137.69.158.60) by SEACASHT02.desktop.isilon.com (137.69.159.81) with Microsoft SMTP Server id 14.1.355.2; Thu, 17 May 2012 23:30:16 -0700 Received: from [137.69.152.66] ([137.69.152.66]) by seaxch12.isilon.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 17 May 2012 23:22:36 -0700 MIME-Version: 1.0 (Apple Message framework v1257) Content-Type: text/plain; charset="windows-1252" From: Garrett Cooper In-Reply-To: <201111180305.pAI35LtC045952@svn.freebsd.org> Date: Thu, 17 May 2012 23:22:38 -0700 Content-Transfer-Encoding: quoted-printable Message-ID: <9AD9BD15-BC6A-4A85-A7BE-EE315AB39ECF@gmail.com> References: <201111180305.pAI35LtC045952@svn.freebsd.org> To: Kevin Lo X-Mailer: Apple Mail (2.1257) X-OriginalArrivalTime: 18 May 2012 06:22:36.0594 (UTC) FILETIME=[9E2F4120:01CD34BE] X-EMM-MHVC: 1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r227650 - in head: lib/libkiconv sys/conf sys/fs/msdosfs sys/fs/smbfs sys/kern sys/libkern sys/modules/libiconv sys/modules/libmchain sys/netsmb sys/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 May 2012 06:30:36 -0000 On Nov 17, 2011, at 7:05 PM, Kevin Lo wrote: > Author: kevlo > Date: Fri Nov 18 03:05:20 2011 > New Revision: 227650 > URL: http://svn.freebsd.org/changeset/base/227650 >=20 > Log: > Add unicode support to msdosfs and smbfs; original pathes from imura, > bug fixes by Kuan-Chung Chiu . >=20 > Tested by me in production for several days at work. Some of the code in this commit breaks unloading of the libiconv module = (it hard locks on unload). In particular if I do the following=85 Index: /root/current/sys/libkern/iconv_ucs.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- /root/current/sys/libkern/iconv_ucs.c (revision 235066) +++ /root/current/sys/libkern/iconv_ucs.c (working copy) @@ -373,6 +373,7 @@ static int iconv_ucs_init(struct iconv_converter_class *dcp) { +#if 0 int error; =20 error =3D iconv_add(ENCODING_UNICODE, ENCODING_UNICODE, = ENCODING_UTF8); @@ -381,6 +382,7 @@ error =3D iconv_add(ENCODING_UNICODE, ENCODING_UTF8, = ENCODING_UNICODE); if (error) return (error); +#endif return (0); } =20 Then unload works (maybe at the cost of leaking a converter or = two). It seems that iconv_unregister_handler succeeds when it's called = (I inserted some printfs just because), but it might be doing bad things = because of restructuring that took place in this commit. Thanks! -Garrett PS Committing kern/168095 beforehand may or may not help...=