From owner-svn-src-head@FreeBSD.ORG Tue Jul 28 18:46:00 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 172B3106567B; Tue, 28 Jul 2009 18:46:00 +0000 (UTC) (envelope-from Tor.Egge@cvsup.no.freebsd.org) Received: from pil.idi.ntnu.no (pil.idi.ntnu.no [129.241.107.93]) by mx1.freebsd.org (Postfix) with ESMTP id 8BA148FC33; Tue, 28 Jul 2009 18:45:58 +0000 (UTC) (envelope-from Tor.Egge@cvsup.no.freebsd.org) Received: from cvsup.no.freebsd.org (c2h5oh.idi.ntnu.no [129.241.103.69]) by pil.idi.ntnu.no (8.14.1/8.13.1) with ESMTP id n6SIjsAx026020 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 28 Jul 2009 20:45:54 +0200 (MEST) Received: from localhost (localhost [127.0.0.1]) by cvsup.no.freebsd.org (8.14.2/8.14.2) with ESMTP id n6SIjsI4049806; Tue, 28 Jul 2009 18:45:54 GMT (envelope-from Tor.Egge@cvsup.no.freebsd.org) Date: Tue, 28 Jul 2009 18:45:41 +0000 (UTC) Message-Id: <20090728.184541.41675682.Tor.Egge@cvsup.no.freebsd.org> To: julian@elischer.org From: Tor Egge In-Reply-To: <4A6F3E4D.3050803@elischer.org> References: <200907250642.n6P6ggKw032784@svn.freebsd.org> <20090728.170954.74706437.Tor.Egge@cvsup.no.freebsd.org> <4A6F3E4D.3050803@elischer.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Virus-Scanned-By: mimedefang.idi.ntnu.no, using CLAMD X-SMTP-From: Sender=, Relay/Client=c2h5oh.idi.ntnu.no [129.241.103.69], EHLO=cvsup.no.freebsd.org X-Scanned-By: MIMEDefang 2.48 on 129.241.107.38 X-Scanned-By: mimedefang.idi.ntnu.no, using MIMEDefang 2.48 with local filter 16.42-idi X-Filter-Time: 1 seconds Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, julian@freebsd.org Subject: Re: svn commit: r195862 - head/sys/netinet/ipfw X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2009 18:46:01 -0000 > ok I wonder where the "right" place to add it is.. probably keep it > at SI_SUB_PROTO_IFATTACHDOMAIN, SI_ORDER_ANY - 256. > > an you check if that fixes it? possibly moving the 256 to 255? That depends on the wanted order between ipfw_init() and vnet_ipfw_init(). Using (SI_SUB_PROTO_IFATTACHDOMAIN, SI_ORDER_ANY - 256) makes the order undefined. Changing the VNET_SYS*INIT() macro arguments in ip_fw2.c from (SI_SUB_KTHREAD_INIT, SI_ORDER_ANY) to (SI_SUB_PROTO_IFATTACHDOMAIN, SI_ORDER_ANY - 255) allows my laptop to boot. I'm not familiar with VIMAGE, and my laptop kernel does not have that option, so I don't know if that will interfere with the initialization order between vnet_ipfw_init() and other VIMAGE/vnet related initializations. - Tor Egge