From owner-cvs-all@FreeBSD.ORG Sun Dec 6 21:24:46 2009 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D651D106568F; Sun, 6 Dec 2009 21:24:46 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from server.mypc.hu (server.mypc.hu [87.229.73.95]) by mx1.freebsd.org (Postfix) with ESMTP id 891348FC15; Sun, 6 Dec 2009 21:24:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by server.mypc.hu (Postfix) with ESMTP id 9F10D14D9E54; Sun, 6 Dec 2009 22:24:45 +0100 (CET) X-Virus-Scanned: amavisd-new at example.com Received: from server.mypc.hu ([127.0.0.1]) by localhost (server.mypc.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id d3EN0cPc9kpI; Sun, 6 Dec 2009 22:24:41 +0100 (CET) Received: from [192.168.1.105] (catv-89-132-179-104.catv.broadband.hu [89.132.179.104]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by server.mypc.hu (Postfix) with ESMTPSA id A962D14D9D67; Sun, 6 Dec 2009 22:24:41 +0100 (CET) Message-ID: <4B1C2114.8080101@FreeBSD.org> Date: Sun, 06 Dec 2009 22:24:36 +0100 From: Gabor Kovesdan User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Adrian Chadd References: <200912060958.nB69wwlm088487@repoman.freebsd.org> <4B1B84DC.3040104@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/www/lusca-head/files patch-ab patch-ac X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Dec 2009 21:24:46 -0000 Adrian Chadd escribió: > I'm sorry for the drive-by commits like this - I had tested the port > locally and deployed it in production; I didn't realise there were so > many issues until after the commit. > > I plan on bumping the port revision once I've established that all of > the post-install issues are fixed. I think they are now. > > I apologies for the noise, > Adrian, there's always a normal mistake factor, we all make mistakes. But for example, looking at your first two follow-up commits after the additon of the port, it seems that there were also very trivial mistakes, which probably could have been found by someone with experience in the ports development. The problem is that you obviously don't have that experience and you take it perfectly natural to commit to something you are not quite competent in without any review or approval request. Even ports committers send a call for reviewers when a port is unusually complex. It is a very important difference between ports and src that the ports tree isn't branched but supposed to be stable, so we do our best to keep it actually as stable as it can be. I'm a ports/doc committer but sometimes I happen to commit to src. But when I do it I always do it with review or approval even if it is a PITA to find someone, who is interested and has time to review my work. But I always do it because I don't want to break anything and actually I don't have privileges to do it without approval. This is the policy described in committers-guide and in the welcome mail from core/portmgr/doceng when one gets a commit bit. And I don't see any reason why it should be different with src committers but as I said this isn't the first case that an src guy breaks something in the doc/ports trees because he thinks he can just figure it out. That's why I got a bit upset but please don't take it personally. In the former cases I always kindly offered help but seems that nothing has changed so I'm getting tired. I think our policies can guarantee the high quality of FreeBSD and I really don't want it to be degraded like in the big chaos of Linux. -- Gabor Kovesdan FreeBSD Volunteer EMAIL: gabor@FreeBSD.org .:|:. gabor@kovesdan.org WEB: http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org