From owner-svn-src-all@FreeBSD.ORG Thu Feb 26 17:46:55 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 044C810656C2; Thu, 26 Feb 2009 17:46:55 +0000 (UTC) (envelope-from rdivacky@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id E64AD8FC1A; Thu, 26 Feb 2009 17:46:54 +0000 (UTC) (envelope-from rdivacky@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n1QHks6s033935; Thu, 26 Feb 2009 17:46:54 GMT (envelope-from rdivacky@svn.freebsd.org) Received: (from rdivacky@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n1QHksAl033934; Thu, 26 Feb 2009 17:46:54 GMT (envelope-from rdivacky@svn.freebsd.org) Message-Id: <200902261746.n1QHksAl033934@svn.freebsd.org> From: Roman Divacky Date: Thu, 26 Feb 2009 17:46:54 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r189077 - head/lib/libcompat/4.3 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2009 17:46:55 -0000 Author: rdivacky Date: Thu Feb 26 17:46:54 2009 New Revision: 189077 URL: http://svn.freebsd.org/changeset/base/189077 Log: Add a missing parameter to ruserpass(). According to C99 6.9.1p7 K&R function is not a prototype but this is a bad style. GCC accepts this other compilers warn or reject this. Approved by: kib (mentor) Modified: head/lib/libcompat/4.3/rexec.c Modified: head/lib/libcompat/4.3/rexec.c ============================================================================== --- head/lib/libcompat/4.3/rexec.c Thu Feb 26 16:32:48 2009 (r189076) +++ head/lib/libcompat/4.3/rexec.c Thu Feb 26 17:46:54 2009 (r189077) @@ -302,7 +302,7 @@ rexec(ahost, rport, name, pass, cmd, fd2 struct hostent *hp; u_short port; int s, timo = 1, s3; - char c; + char c, *acct; hp = gethostbyname(*ahost); if (hp == 0) { @@ -310,7 +310,9 @@ rexec(ahost, rport, name, pass, cmd, fd2 return (-1); } *ahost = hp->h_name; - ruserpass(hp->h_name, &name, &pass); + acct = NULL; + ruserpass(hp->h_name, &name, &pass, &acct); + free(acct); retry: s = socket(AF_INET, SOCK_STREAM, 0); if (s < 0) {