From owner-freebsd-net@FreeBSD.ORG  Thu May 13 06:48:58 2004
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2349516A4CE; Thu, 13 May 2004 06:48:58 -0700 (PDT)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id CE6DB43D2D; Thu, 13 May 2004 06:48:57 -0700 (PDT)
	(envelope-from rizzo@icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
	by xorpc.icir.org (8.12.9p1/8.12.8) with ESMTP id i4DDmvgd045189;
	Thu, 13 May 2004 06:48:57 -0700 (PDT)
	(envelope-from rizzo@xorpc.icir.org)
Received: (from rizzo@localhost)
	by xorpc.icir.org (8.12.9p1/8.12.3/Submit) id i4DDmucg045188;
	Thu, 13 May 2004 06:48:56 -0700 (PDT)
	(envelope-from rizzo)
Date: Thu, 13 May 2004 06:48:56 -0700
From: Luigi Rizzo <rizzo@icir.org>
To: Eugene Grosbein <eugen@kuzbass.ru>
Message-ID: <20040513064856.B42908@xorpc.icir.org>
References: <40A3393F.1391943E@kuzbass.ru>
	<20040513012344.A12373@xorpc.icir.org> <40A34082.F0182B31@kuzbass.ru>
	<20040513013717.A16394@xorpc.icir.org> <40A345F9.1460F5C4@kuzbass.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <40A345F9.1460F5C4@kuzbass.ru>;
	from eugen@kuzbass.ru on Thu, May 13, 2004 at 05:55:05PM +0800
cc: ipfw@freebsd.org
cc: net@freebsd.org
Subject: Re: ipfw: reset tcp
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 13 May 2004 13:48:58 -0000

On Thu, May 13, 2004 at 05:55:05PM +0800, Eugene Grosbein wrote:
...
> > removing the M_SKIP_FIREWALL would let ipfw process the
> > packet too. HOWEVER: i think it is a bug in the general case
> > to reprocess internally-generated packet, because you would rely
> > on a correct ipfw configuration to avoid loops (which might not
> > be the case).
> > 
> > I have no idea how ipfw1 used to do (and i am not goin to check!)
> > but i don't think the generated packet did reenter the firewall.
> 
> I use ipfw2.
> 
> Please make it possible (using sysctl or any other mean) to
> disable M_SKIP_FIREWALL for such packets (I suppose 'unreach' rules
> are affected too). I DO need to process ALL outgoing packets.
> For exapmle, I must use 'ipfw fwd' (to implement policy routing)
> for the packets with source IP like this.

ok the situation is the following:
1.- unreach rules send packets through send_reject() which in turn
  calls icmp_error() which in turn goes through the firewall;
  This is safe because ipfw2 will not generate an ICMP reject
  in response to an ICMP packets so loops are avoided;

2.- all other firewall-generated TCP packets (rst and keepalives)
  go through send_pkt() and then bypass the firewall.
  The only way we could safely go through the firewall again is
  to make sure that we never send a RST in response to a RST (need
  to add an additional check in O_REJECT).

Give me a few days (i.e. ping me again on monday!) to come up with
a safe patch to do this, which does not rely on the programmer to
DTRT and avoid loops.

	cheers
	luigi