From owner-svn-src-head@freebsd.org  Wed Mar  8 21:51:04 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5FFFBD039D7;
 Wed,  8 Mar 2017 21:51:04 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (glebi.us [96.95.210.25])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 48D871AA2;
 Wed,  8 Mar 2017 21:51:03 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id v28LovSd004687
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 8 Mar 2017 13:50:57 -0800 (PST)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id v28LouVd004686;
 Wed, 8 Mar 2017 13:50:56 -0800 (PST)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Wed, 8 Mar 2017 13:50:56 -0800
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Bruce Evans <brde@optusnet.com.au>
Cc: Andriy Gapon <avg@freebsd.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r314862 - head/sys/modules/qlxgbe
Message-ID: <20170308215056.GP1044@FreeBSD.org>
References: <201703071543.v27FhnoL024242@repo.freebsd.org>
 <20170307221733.GN1044@FreeBSD.org>
 <70fcdcf4-cfa5-2382-ea60-55ac1a91e06b@FreeBSD.org>
 <20170308193709.Q2738@besplex.bde.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170308193709.Q2738@besplex.bde.org>
User-Agent: Mutt/1.7.2 (2016-11-26)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Mar 2017 21:51:04 -0000

On Wed, Mar 08, 2017 at 07:47:13PM +1100, Bruce Evans wrote:
B> > On 08/03/2017 00:17, Gleb Smirnoff wrote:
B> >> On Tue, Mar 07, 2017 at 03:43:49PM +0000, Andriy Gapon wrote:
B> >> A> Author: avg
B> >> A> Date: Tue Mar  7 15:43:49 2017
B> >> A> New Revision: 314862
B> >> A> URL: https://svnweb.freebsd.org/changeset/base/314862
B> >> A>
B> >> A> Log:
B> >> A>   qlxgbe: add GCC_MS_EXTENSIONS to CFLAGS to make old base GCC happy
B> >> A>
B> >> A>   The module uses unnamed structure and union fields and base GCC in
B> >> A>   stable/10 doesn't like it.
B> >> A>   I think that that is a C11 feature, so it is courteous of more modern
B> >> A>   compilers to not complain about it when compiling in C99 mode.
B> >>
B> >> There are a lot of code in kernel, that uses anonymous structs and unions.
B> >> This feature is enabled globally. Why does this module need special treatment?
B> 
B> There is not a lot of such code.  There are a lot of ugly macros like
B> 'define v_rdev v_un.vu_cdev' to avoid having such code since it is
B> unportable.

Bruce, I am sorry, I can't resist from asking that in a straight unpolite way:

Unportable to what? Back to XX century?

-- 
Totus tuus, Glebius.