From owner-freebsd-hackers  Mon Sep 18 14:14:33 1995
Return-Path: owner-hackers
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id OAA02905
          for hackers-outgoing; Mon, 18 Sep 1995 14:14:33 -0700
Received: from phaeton.artisoft.com (phaeton.Artisoft.COM [198.17.250.211])
          by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id OAA02898
          ; Mon, 18 Sep 1995 14:14:27 -0700
Received: (from terry@localhost) by phaeton.artisoft.com (8.6.11/8.6.9) id OAA08650; Mon, 18 Sep 1995 14:11:06 -0700
From: Terry Lambert <terry@lambert.org>
Message-Id: <199509182111.OAA08650@phaeton.artisoft.com>
Subject: Re: why is this not a bug in namei?
To: kuku@gilberto.physik.RWTH-Aachen.DE
Date: Mon, 18 Sep 1995 14:11:06 -0700 (MST)
Cc: julian@freefall.freebsd.org, hackers@freefall.freebsd.org
In-Reply-To: <199509180843.KAA08948@gilberto.physik.RWTH-Aachen.DE> from "Christoph Kukulies" at Sep 18, 95 10:43:12 am
X-Mailer: ELM [version 2.4 PL24]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Length: 941       
Sender: owner-hackers@FreeBSD.org
Precedence: bulk

> >                 free(cnp->cn_pnbuf, M_NAMEI);
>                   ^^^^
> Is this just a typo? Shouldn't it be a FREE() macro like below?
> > [...]
> >                 if (error) {
> >                         FREE(cnp->cn_pnbuf, M_NAMEI);
> >                         return (error);

No this is actually the code.

The code is screwed, but it only shows if KMEMSTATS and DIAGNOSTIC are
both undefined (see /sys/sys/malloc.h).

David (?) said he'd go through and mung malloc.h so it wasn't broken
(the non-KMEMSTATS case is an instance of legacy code in malloc.h).

The code should still be cleaned up, however.

I prefer the macroized version to allow later instrumentation.

The access to the system clock timeval should be similarly macroized
for atomicity of access reasons (vnode times update).


					Terry Lambert
					terry@lambert.org
---
Any opinions in this posting are my own and not those of my present
or previous employers.