Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 30 Jun 2016 07:41:09 +0200
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Bryan Drewery <bdrewery@FreeBSD.org>
Cc:        Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r417364 - head/Mk/Scripts
Message-ID:  <20160630054109.beqlksn3juwodf72@ivaldir.etoilebsd.net>
In-Reply-To: <075ef3c9-89f1-8e95-c86a-bf00831c373e@FreeBSD.org>
References:  <201606231131.u5NBVFur021580@repo.freebsd.org> <075ef3c9-89f1-8e95-c86a-bf00831c373e@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--k3kllfottfg77gj6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 29, 2016 at 04:33:52PM -0700, Bryan Drewery wrote:
> On 6/23/2016 4:31 AM, Mathieu Arnold wrote:
> > Author: mat
> > Date: Thu Jun 23 11:31:15 2016
> > New Revision: 417364
> > URL: https://svnweb.freebsd.org/changeset/ports/417364
> >=20
> > Log:
> >   Extend the symlink checks to warn on absolute targets.
> >  =20
> >   Sponsored by:	Absolight
> >   Differential Revision:	https://reviews.freebsd.org/D6930
>=20
> Why? This seems like noise.

Quite true as it is I overlooked it.

To ease relocatable packages (to prepare sysroot for exemple) symlinks that
points to file within the same package should be absolute links.

After looking at this patch again I think it should be reverted and replaced
later by something that will check symlinks on the same plist

Best regards,
Bapt

--k3kllfottfg77gj6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXdLCoAAoJEGOJi9zxtz5aBs8P/3W9RsEKWCSeVyM0+7z7gg3X
itjD9Xy5eOqJEdMuZocDkzr+bYCh5lgWkjbtY1pqx3sR73emciaV+6CRJH7owi+c
3HpD7HT+M+qiHtbmbJlePIHo6ETf1Hp4p73yAxNoIfCm7YjSBsTRSXs+wIQ8UQuj
QwARIED1a3v7IYyxuMFY6GHGmbWUKOPXJeAVLk5hs/1gOE63I7okzxkhsIivVXP9
8WUCCr08kgDgAexTg6pBggeEOEqFizIkthpVWhnbaFBWHoRuH0Q/hdR4PYG5B8yH
aGlbqv0tl3jPJrihDElw3ij4L27D/dIRo/dBeELX2cHjbOeaSeS/4bI0R1F+TmH4
/PsqaLS0hm/tRKsDxy+lwPIfrtdXgeJv9EyGt2VwGAivUQbsIpEsTxIVjtP2B/+0
q6+oA3M8y/ioiwuXuUcVU9NFxnog2PMmMAzAEoCohDbVueVuSKO6Ez67IC7F/1UT
xSLFgUthchYySLrNojRS/miNWAKGXRcLeVsgqRqy4titswYim5Uv9ia3OIHYlLBY
WMc7h6gIIEXPjGdjvJSZX/1wqlT0QSqS1j/MGPEi8QY9oCsAI7hmRlJuXYCrzg5j
Ko7IPHBKiby/m1xxnjah2sDZchwsSjdWcle1P9e/aQl5M5521qWJn21NFUBhyAOX
ThIm6xHli+AOPqCYZExj
=KAS7
-----END PGP SIGNATURE-----

--k3kllfottfg77gj6--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160630054109.beqlksn3juwodf72>