From owner-freebsd-multimedia@FreeBSD.ORG Tue Nov 8 16:20:21 2005 Return-Path: X-Original-To: freebsd-multimedia@freebsd.org Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2FABA16A421 for ; Tue, 8 Nov 2005 16:20:08 +0000 (GMT) (envelope-from skywizard@MyBSD.org.my) Received: from tomoyo.MyBSD.org.my (tomoyo.mybsd.org.my [202.157.186.227]) by mx1.FreeBSD.org (Postfix) with ESMTP id 69AB943D5E for ; Tue, 8 Nov 2005 16:20:07 +0000 (GMT) (envelope-from skywizard@MyBSD.org.my) Received: from localhost (localhost [127.0.0.1]) by tomoyo.MyBSD.org.my (Postfix) with ESMTP id BB8A76CC26; Wed, 9 Nov 2005 00:22:22 +0800 (MYT) Received: from tomoyo.MyBSD.org.my ([127.0.0.1]) by localhost (TOMOYO.MYBSD.ORG.MY [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 78324-10; Wed, 9 Nov 2005 00:22:21 +0800 (MYT) Received: from kasumi.MyBSD.org.my (kasumi.MyBSD.org.my [IPv6:2001:328:2002:aa2::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tomoyo.MyBSD.org.my (Postfix) with ESMTP id 3812A6CC23; Wed, 9 Nov 2005 00:22:20 +0800 (MYT) Date: Wed, 9 Nov 2005 00:20:13 +0800 From: Ariff Abdullah To: Alexander Leidinger Message-Id: <20051109002013.4dcf3c0d.skywizard@MyBSD.org.my> In-Reply-To: <20051108165955.ge235sro0848csok@netchild.homeip.net> References: <20051108153556.C856C253D6@mail.asahi-net.or.jp> <20051108165955.ge235sro0848csok@netchild.homeip.net> Organization: MyBSD X-Mailer: /usr/local/lib/ruby/1.8/net/smtp.rb Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: by Amavisd AntiVirus & AntiSpam Scanner running on FreeBSD mailserver at TOMOYO.MYBSD.ORG.MY Cc: freebsd-multimedia@freebsd.org, CQG00620@nifty.ne.jp Subject: Re: [patch] stereo input is mixed to monaural via SoundBlaster16 recording mixer X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2005 16:20:21 -0000 On Tue, 08 Nov 2005 16:59:55 +0100 Alexander Leidinger wrote: > Watanabe Kazuhiro wrote: > > > if (src & SOUND_MASK_MIC) > > - recdev |= 0x01; /* mono mic */ > > + recdev_l |= 0x01; /* mono mic */ > > + recdev_r |= 0x01; > > If I understand this correctly, this feeds the monaural signal to > the left and the right channel. When we have a mono input, do we > really want to have the same input doubled? I don't do any > recording, so I don't know how most programs handle this, but IMHO > it's a waste of resources and if the source is only able to deliver > a mono-signal, the recording should only be possible in mono. > > Does this sound sane? > Watanabe-san, I would suggest you to put braces along with the conditional statement so the code become much easier tu understand. Without it, it seems that recdev_r will always be set even if the condition is false. > Be warned, if you proceed to submit such patches, we may want to > lure you into becomming a committer... > -- Ariff Abdullah MyBSD http://www.MyBSD.org.my (IPv6/IPv4) http://staff.MyBSD.org.my (IPv6/IPv4) http://tomoyo.MyBSD.org.my (IPv6/IPv4)