From owner-freebsd-current@FreeBSD.ORG  Sat Jul  9 13:46:14 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@FreeBSD.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1481716A41C;
	Sat,  9 Jul 2005 13:46:14 +0000 (GMT)
	(envelope-from phk@phk.freebsd.dk)
Received: from haven.freebsd.dk (haven.freebsd.dk [130.225.244.222])
	by mx1.FreeBSD.org (Postfix) with ESMTP id ADCB443D46;
	Sat,  9 Jul 2005 13:46:13 +0000 (GMT)
	(envelope-from phk@phk.freebsd.dk)
Received: from phk.freebsd.dk (unknown [192.168.48.2])
	by haven.freebsd.dk (Postfix) with ESMTP id 7B593BC83;
	Sat,  9 Jul 2005 13:46:12 +0000 (UTC)
To: John Baldwin <jhb@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sat, 09 Jul 2005 09:32:11 EDT."
	<200507090932.12973.jhb@FreeBSD.org> 
Date: Sat, 09 Jul 2005 15:46:12 +0200
Message-ID: <20514.1120916772@phk.freebsd.dk>
Sender: phk@phk.freebsd.dk
Cc: Poul-Henning Kamp <phk@haven.freebsd.dk>, freebsd-current@FreeBSD.org,
	current@FreeBSD.org
Subject: Re: [TEST/REVIEW] boot0cfg/fdisk issue fix 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Jul 2005 13:46:14 -0000

In message <200507090932.12973.jhb@FreeBSD.org>, John Baldwin writes:
>On Tuesday 05 July 2005 04:44 pm, Poul-Henning Kamp wrote:
>> This is an attempt to fix an boot0cfg/fdisk issue which I have
>> overlooked.
>>
>> The patch adds a g_ctl method to geom_mbr and makes boot0cfg and
>> fdisk use it to modify the MBR if possible.
>>
>> Please test and report ASAP in order to get this solution into
>> RELENG_6
>
>Only thing I noted is that it seems that you changed boot0 to always only 
>write 512 bytes which means it will break trying to use boot0cfg to install 
>boot0ext (which is 2 sectors).  Perhaps you should check the filesize of the 
>boot you are writing and if it's > 512, write the other data with a write(2) 
>after the g_ctl()?  Perhaps I don't see quite understand what your g_ctl() is 
>doing though.

Damn, didn't think of that...

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.