From owner-freebsd-current@FreeBSD.ORG Tue Sep 28 17:32:22 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AED1816A4CE for ; Tue, 28 Sep 2004 17:32:22 +0000 (GMT) Received: from mail.freebsd.org.cn (dns3.freebsd.org.cn [61.129.66.75]) by mx1.FreeBSD.org (Postfix) with SMTP id DB02443D2F for ; Tue, 28 Sep 2004 17:32:18 +0000 (GMT) (envelope-from delphij@frontfree.net) Received: (qmail 19540 invoked by uid 0); 28 Sep 2004 17:28:12 -0000 Received: from unknown (HELO beastie.frontfree.net) (219.239.98.7) by mail.freebsd.org.cn with SMTP; 28 Sep 2004 17:28:12 -0000 Received: from localhost (localhost.frontfree.net [127.0.0.1]) by beastie.frontfree.net (Postfix) with ESMTP id 5ED90132415; Wed, 29 Sep 2004 01:32:14 +0800 (CST) Received: from beastie.frontfree.net ([127.0.0.1]) by localhost (beastie.frontfree.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 01998-04; Wed, 29 Sep 2004 01:32:10 +0800 (CST) Received: by beastie.frontfree.net (Postfix, from userid 1001) id C66BA1323DC; Wed, 29 Sep 2004 01:32:08 +0800 (CST) Date: Wed, 29 Sep 2004 01:32:08 +0800 From: Xin LI To: Matthias Andree Message-ID: <20040928173208.GA277@frontfree.net> References: <20040927224353.845381B217@merlin.emma.line.org> <20040928043351.GA2400@frontfree.net> <20040928071758.GB14942@ip.net.ua> <20040928153537.GA3185@frontfree.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yrj/dFKFPuw6o+aM" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i X-GPG-key-ID/Fingerprint: 0xCAEEB8C0 / 43B8 B703 B8DD 0231 B333 DC28 39FB 93A0 CAEE B8C0 X-GPG-Public-Key: http://www.delphij.net/delphij.asc X-Operating-System: FreeBSD beastie.frontfree.net 5.3-delphij FreeBSD 5.3-delphij #4: Mon Sep 13 12:44:05 CST 2004 delphij@beastie.frontfree.net:/usr/obj/usr/src/sys/BEASTIE i386 X-URL: http://www.delphij.net X-By: delphij@beastie.frontfree.net X-Location: Beijing, China X-Virus-Scanned: by amavisd-new at frontfree.net cc: Ruslan Ermilov cc: Matthias Andree cc: current@FreeBSD.org Subject: Re: bin/72138: libc.so.5 isn't installed in a safe way X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Sep 2004 17:32:22 -0000 --yrj/dFKFPuw6o+aM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 28, 2004 at 07:05:11PM +0200, Matthias Andree wrote: > X-Sieve: CMU Sieve 2.2 > To: Xin LI > Cc: Matthias Andree , > Ruslan Ermilov , > Matthias Andree , current@FreeBSD.org > Subject: Re: bin/72138: libc.so.5 isn't installed in a safe way > In-Reply-To: <20040928153537.GA3185@frontfree.net> (Xin LI's message of "= Tue, > 28 Sep 2004 23:35:37 +0800") > From: Matthias Andree > Date: Tue, 28 Sep 2004 19:05:11 +0200 > User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (gnu/linux) > X-Virus-Scanned: by amavisd-new at frontfree.net >=20 > Xin LI writes: >=20 > > So I personally prefer we have -S for the shared libraries (as Ruslan's > > patch did) - and give our user community the choose of whether to have > > INSTALL=3Dinstall -S in their make.conf. > > > > What do you think about this? >=20 > It is important that a failing "make installworld" doesn't leave a > non-working system behind. I don't care much about temporary files left > over. I concur that it's important, however, it is much less by chance when faili= ng to install binaries then failing to install shared objects, because the latter would cause serious problem with *all* binaries when they are dynamically linked newadays. Generally speaking I've no idea why general binaries should be installed in ``safe mode'' because: - Little chances that lacking one binary will cause an unbootable system. If you have different idea, we may probably list them individually rather than having everything installed in ``safe mode'', as most of the binaries won't cause problem even they are deleted. We can live without ``rm'' because we can still ``make install'' it... - Users who feel this important can still set INSTALL=3Dinstall -S instead of the default make.conf value. - Rename operation might be expensive in some situation, for instance, a flash disk. Their life is limited by re-writes and -S will cause four writes. It seems to me, however, a good compromise to document this in make.conf rather than making it default. Maybe we can make the following changes: - Have INSTALL_BIN_FLAGS, INSTALL_LIB_FLAGS, INSTALL_SHLIB_FLAGS, INSTALL_DOC knobs which control the installation of binaries, libraries, shared objects, documentations, while retaining the INSTALL as the all-over knob. - Change ${INSTALL} foo $[BINPATH}/bar into ${INSTALL} ${INSTALL_BIN_FLAGS} foo ${BINPATH}/bar or so forth. With this change, we can control whether documentation is or is not installed in safe mode. However, this change may need more tests so I'd ratherr having Ruslan's patch in the tree first (and I highly recommend that it should be MFC'ed to RELENG_5 and the upcoming RELENG_5_3), and consider the above after 5.3-RELEASE. Will that helpful? Cheers, --=20 Xin LI http://www.delphij.net/ See complete headers for GPG key and other information. --yrj/dFKFPuw6o+aM Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBWaAY/cVsHxFZiIoRAkEeAJ9Ygkhk6xWflvHhbK6c8qNAfo5uOACfb5I4 uiNijXqFH4DhIpWfQ08dHkk= =JhVj -----END PGP SIGNATURE----- --yrj/dFKFPuw6o+aM--