From owner-svn-src-all@FreeBSD.ORG Fri Jul 23 19:18:14 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0D7A1106564A; Fri, 23 Jul 2010 19:18:14 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 76CC58FC19; Fri, 23 Jul 2010 19:18:12 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o6NJI8NA051784 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 23 Jul 2010 22:18:08 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o6NJI85M007964; Fri, 23 Jul 2010 22:18:08 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o6NJI8Gd007963; Fri, 23 Jul 2010 22:18:08 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 23 Jul 2010 22:18:08 +0300 From: Kostik Belousov To: Alan Cox Message-ID: <20100723191808.GV2381@deviant.kiev.zoral.com.ua> References: <201007231858.o6NIwRR3087236@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="33c4aGQrRAPGVH9y" Content-Disposition: inline In-Reply-To: <201007231858.o6NIwRR3087236@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.5 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r210429 - in head/sys: amd64/linux32 compat/freebsd32 kern sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jul 2010 19:18:14 -0000 --33c4aGQrRAPGVH9y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 23, 2010 at 06:58:27PM +0000, Alan Cox wrote: > Author: alc > Date: Fri Jul 23 18:58:27 2010 > New Revision: 210429 > URL: http://svn.freebsd.org/changeset/base/210429 >=20 > Log: > Eliminate a little bit of duplicated code. >=20 I think that amd64 copy of linux_exec_copyin_args() can go out as well. COMPAT_LINUX32 or linux.ko requires COMPAT_FREEBSD32, and the function seems to be identical to freebsd32_exec_copyin_args(), except there is missed check for fname !=3D NULL. --33c4aGQrRAPGVH9y Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkxJ6u8ACgkQC3+MBN1Mb4ildwCfSVGYDj8x0js1i+h3gcc8cqbV 6YEAoMsWNPYM9SYhhacFNKkG0XSTXOzj =s6LZ -----END PGP SIGNATURE----- --33c4aGQrRAPGVH9y--