Date: Thu, 04 Sep 2014 10:37:33 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 193185] [stage] net/ipsorc MASTER_SITES LICENSE WWW take maintainership Message-ID: <bug-193185-13-aIC3zcdakc@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-193185-13@https.bugs.freebsd.org/bugzilla/> References: <bug-193185-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193185 --- Comment #19 from C Hutchinson <portmaster@bsdforge.com> --- (In reply to John Marino from comment #16) > (In reply to C Hutchinson from comment #15) > > I can see the pattern(s) here. Especially now _knowing_ that > > most of the ports files are in an 8-space tab format. > > > Not most, all. Anything that is exception needs to be changed. > > > > I can easily count, and you have also noted their [preferred] numbers. > > So long as I use the correct count, everyone will be happy. No? > > > > I have no intention, nor desire to be "sloppy". But I think > > everyone can win, in this particular case. No? > > > I truly don't believe that. You will make a mistake, because it's an easy > mistake to make. I would also make a mistake if I tried it. I know, > because I've tried this before. And you will deserve the criticism because > you were strongly advised not to try it. > > > > Just saying, not serious. > > > I can't tell when you are joking, it's best to play this straight. I've > been trying to help you contribute high quality submissions and I take what > you say seriously. > > > > Right you are! Definitely, my bad. > > I took a short cut here, and _really_ should have known better. > > In short; I tried to make what was already there work. Rather than do it > > _correctly_ > > > I want to be fair. What you have should work. At least, I don't see an > immediate issue with it. This is a conformity / preference issue. > > > > When check-plist complained, the impression I got, was that it didn't like > > the lines deleting the doc files. So I simply attempted to blow away the > > docs dir that was added, which ultimately clobbered the files, as well. > > It was clumsy, and I _really_ should have clobbered all the lines, and > > added correct ones. In the end the block would have been shorter, anyway. > > Prettier too. > > I'm not sure I follow. When you define PORTDOCS, you get to remove all the > lines starting with %%PORTDOCS%% in the pkg-plist. Not only get to, you > have to, otherwise it gets added to the final list twice and fails to remove > it twice during deinstallation > > > It came with the original. But it clobbers the added folder in share/docs. > > So I left it. If it bothers you. I'll re-create it from scratch. > > remove DOCSDIR definition please. > > Let's see "make check-plist" after that. Just for the record, and _in spite_ of anything I [might] say, to the contrary. I _do_ appreciate your critique. I'm under pressure, sometimes to get things done, or it's late, and I'm tired (it's 3:30am now). I _may_ seem contrary. But I _do_ [eventually] catch wind of my [better] senses. So _know_, I _do_ appreciate it. Thanks, John. I hope you find my latest changes to all this. More to your liking. OH, and don't get rid of that stick, you keep whacking me with, just yet. I may yet need a couple more. I'm stubborn [like you haven't noticed] :) --Chris -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193185-13-aIC3zcdakc>