From owner-dev-commits-src-main@freebsd.org  Mon Apr 26 16:51:58 2021
Return-Path: <owner-dev-commits-src-main@freebsd.org>
Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1B15A5E7B8F;
 Mon, 26 Apr 2021 16:51:58 +0000 (UTC) (envelope-from nc@freebsd.org)
Received: from rainpuddle.neelc.org (rainpuddle.neelc.org
 [IPv6:2001:19f0:8001:fed:5400:2ff:fe73:c622])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4FTWC16jNSz3rHK;
 Mon, 26 Apr 2021 16:51:57 +0000 (UTC) (envelope-from nc@freebsd.org)
Received: from mail.neelc.org (rainpuddle.neelc.org
 [IPv6:2001:19f0:8001:fed:5400:2ff:fe73:c622])
 by rainpuddle.neelc.org (Postfix) with ESMTPSA id 9CD84EB2BD;
 Mon, 26 Apr 2021 09:51:56 -0700 (PDT)
MIME-Version: 1.0
Date: Mon, 26 Apr 2021 09:51:56 -0700
From: Neel Chauhan <nc@freebsd.org>
To: Kevin Bowling <kevin.bowling@kev009.com>
Cc: src-committers <src-committers@freebsd.org>,
 dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject: Re: git: e657f3de6dc2 - main - linuxkpi: Remove unneeded {} in
 atomic_dec_and_lock_irqsave()
In-Reply-To: <CAK7dMtDuJ_4z2Xwej1hpGcXC6LaP5Wwo5ymbA_4-tds22spOgg@mail.gmail.com>
References: <202104261525.13QFPrbg086311@gitrepo.freebsd.org>
 <CAK7dMtDuJ_4z2Xwej1hpGcXC6LaP5Wwo5ymbA_4-tds22spOgg@mail.gmail.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <9b006e97a64d01d128d81bc09f0891ea@freebsd.org>
X-Sender: nc@freebsd.org
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 4FTWC16jNSz3rHK
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-BeenThere: dev-commits-src-main@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for the main branch of the src repository
 <dev-commits-src-main.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-main/>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Help: <mailto:dev-commits-src-main-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Apr 2021 16:51:58 -0000

On 2021-04-26 09:47, Kevin Bowling wrote:
> I'm not sure all the context or conversation here but the convention
> is to not use bare return values, i.e in style(9) "Values in return
> statements should be enclosed in parentheses." and that's what was
> asked to be changed on this mailing list.

The review: https://reviews.freebsd.org/D29988

I believe I was asked to do this in the review.

-Neel
> 
> Can you use and link to Phabricator for your src commits?  As much as
> possible it is preferable to get it right in one go, for MFCs,
> bisection, etc and this kind of churn should be preventable with quick
> reviews.  Feel free to tag me as a reviewer.

Sure, will do next time.


> Regards,
> Kevin

-Neel