From owner-svn-src-head@FreeBSD.ORG  Sat Mar 13 22:06:42 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8F451106566B;
	Sat, 13 Mar 2010 22:06:42 +0000 (UTC)
	(envelope-from onemda@gmail.com)
Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.27])
	by mx1.freebsd.org (Postfix) with ESMTP id CB5708FC13;
	Sat, 13 Mar 2010 22:06:41 +0000 (UTC)
Received: by ey-out-2122.google.com with SMTP id 25so140001eya.9
	for <multiple recipients>; Sat, 13 Mar 2010 14:06:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:in-reply-to:references
	:date:message-id:subject:from:to:cc:content-type;
	bh=1ysocnjk9/wCNrdsVsHW0L4D2X42p+8nKj0i3vysomQ=;
	b=sk4DiOx9jkpX1n/MWFP/DcVWqNjNEVoIj+4CMW/IyyFVLiGNUrrOWe0Pe8QfR8hn4L
	gBfs7amy8K4xxIYIA+sZhs8uKRIGxSfc8h50NDp5dghEtDmE5SgejMu4HMVQcr0brsdz
	uUVBHc+mg2Ck/JoGszoGSJH7BgYDbuA4EzGOg=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	b=sfdUsvnhYy+ZvONV5TsVvIw5mljgeJ78jbQSQdEv6GomiyZSOBlmNVBz+VYKzOzZKr
	cWXZyD5hg+8iqmV0LM8CQ2l91CcbcE5d5UslCpDCphdhV6lFb4NceJvHW2LFbh65WeQg
	Y/pq3wWA/BLiY0MCF3SchR+d5pXT2aontej0M=
MIME-Version: 1.0
Received: by 10.213.55.73 with SMTP id t9mr3834675ebg.31.1268518000550; Sat, 
	13 Mar 2010 14:06:40 -0800 (PST)
In-Reply-To: <201003111756.o2BHukJu042449@svn.freebsd.org>
References: <201003111756.o2BHukJu042449@svn.freebsd.org>
Date: Sat, 13 Mar 2010 22:06:40 +0000
Message-ID: <3a142e751003131406y5ba76e3ckcd0e9b4626089faa@mail.gmail.com>
From: Paul B Mahol <onemda@gmail.com>
To: Qing Li <qingli@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r205024 - head/sys/net
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Mar 2010 22:06:42 -0000

On 3/11/10, Qing Li <qingli@freebsd.org> wrote:
> Author: qingli
> Date: Thu Mar 11 17:56:46 2010
> New Revision: 205024
> URL: http://svn.freebsd.org/changeset/base/205024
>
> Log:
>   The if_tap interface is of IFT_ETHERNET type, but it
>   does not set or update the if_link_state variable.
>   As such RT_LINK_IS_UP() fails for the if_tap interface.
>
>   Also, the RT_LINK_IS_UP() needs to bypass all loopback
>   interfaces because loopback interfaces are considered
>   up logically as long as the system is running.
>
>   This patch fixes the above issues by setting and updating
>   the if_link_state variable when the tap interface is
>   opened or closed respectively. Similary approach is
>   already done in the if_tun device.
>
>   MFC after:	3 days
>
> Modified:
>   head/sys/net/if_tap.c
>   head/sys/net/route.h

Look at /sys/dev/if_ndis.c it is still broken.