From owner-svn-src-all@freebsd.org Tue Apr 19 20:37:31 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E1036B15249; Tue, 19 Apr 2016 20:37:31 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: from mail-yw0-x22d.google.com (mail-yw0-x22d.google.com [IPv6:2607:f8b0:4002:c05::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9D5961AAD; Tue, 19 Apr 2016 20:37:31 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: by mail-yw0-x22d.google.com with SMTP id t10so31546377ywa.0; Tue, 19 Apr 2016 13:37:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=mZWZbpPfx9j2MxNOxdoBXMzZHbr+E3sv8a0G/aMGkbI=; b=Re/8HahoH2zOb4M+YHAN18P/VrQi+kwuS8nKYe04MoHaNXCdfbK60jB8jaeMiIkk+3 4Zx8smOeOI/SALrZn+Lj8txpnh1gKjZdQ/p5pCfiWVg1LrqhB6BottbLFXukzON4kB0e F2iuXKfrMKBZOHU2pS4D4YYs1zjz6wb+mNketK4fYHXcM9BlT5JQUy2BhATUGStzTY2G egUoQC9XpJILg6cntL+PsGtY4+n9uujKUAS0ax2KMGfSXbYMaiHIWRPgzfvUanyOl/cs q/jc/NMTlED74wt62y4P3bim2LcMf0VSbi9+J1NraJS2tFN9fxINktXzP4Bagl5WZzyV CIgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=mZWZbpPfx9j2MxNOxdoBXMzZHbr+E3sv8a0G/aMGkbI=; b=ZeF3MnNVtPw7Yagr1msLfiorqVdhrke16vthepRiOZhllTDGd+vs97sU3bt+KKP79P N+RvpV/8mgV5mmy/LapQvtIM3/5u2OPvHER3oQYzzL5p+9vTuycBzeSZe/riWt9nWLA0 uZsWRow2GehejKMaPC1+Z2MGJzifA4s992z3rpaU1UD4kY5DK+csmWEnNPIwi7M+raNe 5cQmonqB6f//vIVxGG+sdLQjXA5sMhW7UkNEfBPN6yY9jqIq39gDjmfVfuvmFhp7gEFp UlEVzWe1CKLvl1xzcqZZCPalXSYzY/W3ZjllajavkBVxNyv15zKqWok8eXST/moKaS6p ew4g== X-Gm-Message-State: AOPr4FV8thzMpOUzmY9sFYK18Gt68yOSiliqs3I1/drNCUWWfmFu45RWANOiqVDzu44KfWFFgoI1/whUvMp49w== MIME-Version: 1.0 X-Received: by 10.37.87.135 with SMTP id l129mr3131387ybb.7.1461098250809; Tue, 19 Apr 2016 13:37:30 -0700 (PDT) Sender: pkelsey@gmail.com Received: by 10.129.27.14 with HTTP; Tue, 19 Apr 2016 13:37:30 -0700 (PDT) In-Reply-To: <1461097280.1232.34.camel@freebsd.org> References: <201604191539.u3JFdkHx048678@repo.freebsd.org> <20160419171243.GA30453@bsdpad.com> <1461097280.1232.34.camel@freebsd.org> Date: Tue, 19 Apr 2016 16:37:30 -0400 X-Google-Sender-Auth: FubPsHy14OrE9nXwLbLsnZpRrTw Message-ID: Subject: Re: svn commit: r298274 - head/sys/dev/spibus From: Patrick Kelsey To: Ian Lepore Cc: Juli Mallett , Adrian Chadd , Ruslan Bukin , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2016 20:37:32 -0000 On Tue, Apr 19, 2016 at 4:21 PM, Ian Lepore wrote: > On Tue, 2016-04-19 at 13:17 -0700, Juli Mallett wrote: > > Patrick Kelsey offered an mmcspi driver for FreeBSD, but nobody > > seemed > > interested. I know of one proprietary branch of FreeBSD using it. > > You might poke him if you want to know how he dealt with this, and if > > you want to commit his driver. > > > > Patrick is a committer, maybe he should just commit it. :) > What I believe originally held up that driver being committed (by others - this was before my commit bit) was that I relied on some out-of-tree spibus changes Luiz had made (as I recall, mainly being able to reserve the SPI bus for multiple transactions), and getting those into the tree would have required updating/testing other existing SPI drivers, based on feedback I received at the time. All I had was the RB450G that I developed and tested the driver with, so I really couldn't address that issue, and then work took me in some other direction entirely. Some or all of these spibus changes that I relied on might now be in the tree, I'm not sure offhand. I am sure though that a huge stack of other things I need to get through has chronically kept me from updating that driver to current and retesting. When I wrote that driver, I put a lot of effort into testing it against as many different cards as I could obtain at the time - I believe 30 or so in total, all the details are in the code that was posted to the list back then. I encountered a number of strange/unexpected behaviors in that set of cards, and all of that hard-won knowledge is in that driver, including a much less complex fix for a shifted-response-data issue than you will see if you look at the Linux mmcpsi driver (as I recall, the Linux driver has code to arbitrarily bit-shift card response data, and to detect when that should be done, but it turns out that can be avoided entirely by inserting idle cycles in the right place when sending the command). -Patrick