From owner-freebsd-hackers@FreeBSD.ORG  Fri Jun  4 15:34:08 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AC34F106566B;
	Fri,  4 Jun 2010 15:34:08 +0000 (UTC) (envelope-from jilles@stack.nl)
Received: from mx1.stack.nl (relay04.stack.nl [IPv6:2001:610:1108:5010::107])
	by mx1.freebsd.org (Postfix) with ESMTP id 710CE8FC16;
	Fri,  4 Jun 2010 15:34:08 +0000 (UTC)
Received: from turtle.stack.nl (turtle.stack.nl [IPv6:2001:610:1108:5010::132])
	by mx1.stack.nl (Postfix) with ESMTP id 7201F1DD656;
	Fri,  4 Jun 2010 17:34:07 +0200 (CEST)
Received: by turtle.stack.nl (Postfix, from userid 1677)
	id 5F9311721B; Fri,  4 Jun 2010 17:34:07 +0200 (CEST)
Date: Fri, 4 Jun 2010 17:34:07 +0200
From: Jilles Tjoelker <jilles@stack.nl>
To: Gabor Kovesdan <gabor@FreeBSD.org>
Message-ID: <20100604153407.GA45024@stack.nl>
References: <4C08DC5A.4020409@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C08DC5A.4020409@FreeBSD.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: Edwin Groothuis <edwin@mavetju.org>, FreeBSD Hackers <hackers@freebsd.org>,
	d@delphij.net
Subject: Re: libc symbol versioning difficulties with iconv integration
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jun 2010 15:34:08 -0000

On Fri, Jun 04, 2010 at 12:58:34PM +0200, Gabor Kovesdan wrote:
> I'm trying to integrate the result of my last SoC work to the base 
> system but I'm facing some difficulties with libc symbol versioning. I 
> placed the iconv code into an iconv subdirectory inside src/lib/libc and 
> I added a Makefile and a symbol map, just like another parts of libc do 
> but when I try to compile this stuff, I get this error in the linking phase:

> building shared library libc.so.7
> /usr/bin/ld: libc.so.7: undefined versioned symbol namefts_open@FBSD_1.0
> /usr/bin/ld: failed to set dynamic section sizes: Bad value
> *** Error code 1

> I have no idea what's going wrong because I did everything exactly in 
> the same way as another components do. I don't know why does it break at 
> fts_open(), which is unrelated to iconv, not even used in the iconv 
> code. If I just unhook the iconv part fromt he build, everything goes 
> fine. Any ideas?

> Patch is here: http://kovesdan.org/patches/iconv-libc.diff

There is a  .include <bsd.lib.mk>  in iconv/Makefile.inc, what happens
if you take that out?

-- 
Jilles Tjoelker