From owner-freebsd-current@FreeBSD.ORG  Sun May  9 16:09:16 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C3BF716A4CE
	for <current@freebsd.org>; Sun,  9 May 2004 16:09:16 -0700 (PDT)
Received: from rwcrmhc11.comcast.net (rwcrmhc11.comcast.net [204.127.198.35])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A6DAD43D31
	for <current@freebsd.org>; Sun,  9 May 2004 16:09:16 -0700 (PDT)
	(envelope-from julian@elischer.org)
Received: from interjet.elischer.org ([24.7.73.28])
          by comcast.net (rwcrmhc11) with ESMTP
          id <20040509230916013002g8qve>; Sun, 9 May 2004 23:09:16 +0000
Received: from localhost (localhost.elischer.org [127.0.0.1])
	by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id QAA24702
	for <current@FreeBSD.ORG>; Sun, 9 May 2004 16:09:15 -0700 (PDT)
Date: Sun, 9 May 2004 16:09:14 -0700 (PDT)
From: Julian Elischer <julian@elischer.org>
To: FreeBSD current users <current@FreeBSD.ORG>
Message-ID: <Pine.BSF.4.21.0405091556030.24403-100000@InterJet.elischer.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: exit1()/scheduler question.. possible typo?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 09 May 2004 23:09:16 -0000


in exit1 there is an assertion to test that the exiting process
is not init. (proc 1 by tradition..)

yes later, nearly at the end we see:

        /*
         * Allow the scheduler to adjust the priority of the
         * parent when a kseg is exiting.
         */
        if (p->p_pid != 1)
                sched_exit(p->p_pptr, td);
 

firstly, the comment is wrong but, the question comes..
"if init can not get here then why have the test?"

I get the impression that possibly this should be p->p_pptr->p_ppid
but I don't know enough about ULE to know if that makes sense.

(maybe it should be (p->p_pptr != initproc)