From owner-dev-commits-src-main@freebsd.org Mon Apr 12 17:15:29 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D95D05D7D08; Mon, 12 Apr 2021 17:15:29 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FJwNd5p6Nz4gjq; Mon, 12 Apr 2021 17:15:29 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1618247729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fqm8SfMUVGMD82yvDKv0WZLSyVzZgApNx2q4pyrafBU=; b=m7NxNE5R8HMsxEdIn6uoUecGp93EquHI2QXdk2bnnuGi6vu3eeVhccEoEe3BWraXryYa6r i5bkC/XDmU0yD/M5dfDqEiIGezcqaucRIT2KgG/DnBqCvRIpLjY/7GaIyR/QOB8nKpFXn4 P+oNgM40SpBsNf8As9RgqOHwOPIgeBvQCejt+mALzaA7lRBFvPgevTorfZqwEIFQM1Pw3i qIO9hAe43NwbsBmA4uyau5UQ+LMXS8IiLGScufuoscURuGsq6twfaDe5o4g5PycX0jdZDn cfkNUJnU7R4hPbaBK9VHFmoXXqpi/0pcYSTVpWidzxMw8IeOH+MXVDA8IifDig== Received: by freefall.freebsd.org (Postfix, from userid 1033) id BDD4EFB40; Mon, 12 Apr 2021 17:15:29 +0000 (UTC) Date: Mon, 12 Apr 2021 17:15:29 +0000 From: Alexey Dokuchaev To: Cy Schubert Cc: Mark Johnston , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: dfff37765ce4 - main - Rename struct device to struct _device Message-ID: <20210412171529.GA24055@FreeBSD.org> References: <202104121336.13CDaI5A029079@gitrepo.freebsd.org> <202104121430.13CEUUIq030729@slippy.cwsent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202104121430.13CEUUIq030729@slippy.cwsent.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1618247729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fqm8SfMUVGMD82yvDKv0WZLSyVzZgApNx2q4pyrafBU=; b=tPRkYVVpYnwt5aXrd2crRAAPNw9LloomRaIk/ffDeaV6IeuG9tgw81L2X7oth0kWEzZwJQ fn9XjGSFQEXiREbCTqHSQ4QlF0Q21hjOYac74DupY/dfoyV+ThZHL7UM7b3GEg+gV4l/9O 7e9NwXhVWqUfiiMQ5oULYQ90LH6bqnw92WrUxJSIMskdPysO5RK0ri2r9zfr3RphWJIPKv prlV/CIy4BOuqvZStyzXs7+q+mhx9WO0D5ABL+vIL3EbkU0cRWWqgp4471RHBntrJM+tIe Rvw2ttu7fQdp9g7O9QJnNovAlQhD1F4BknPcvdfzXAiItk7FXOtDtEJ2ol2oxw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1618247729; a=rsa-sha256; cv=none; b=j+KwDgoyAYudKp9/NKDAPGL3Vah5UT2Qshz3uJsXUgeXDuhUj101+wRydt+0vyYt0QTQkx AAWr9u7HNvIAVk9+22h/Mvac4W6f1EsM/qLybLMbt2hYu5Qguyt/RfzDmOi/8tVP8VzeJG j2fal+9xdKqviRqWhlReRzRqSaMJEdHG+KbM0Ml02Gxd6csV/0znYcRlw7O57WAAOG1cVg irhIA9yAR1PKYleLMe5FRwDjjbmxpQWOeUWSTdMJ2skBMBTgNFB97X2gGshoEsGIF2JVin RkDknv6GMycpUSSLiM+Zjg0aMiYbsR1Hzs6LmbLqf6s2K0gBojCjKrnvyxywUw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Apr 2021 17:15:29 -0000 On Mon, Apr 12, 2021 at 07:30:30AM -0700, Cy Schubert wrote: > Mark Johnston writes: > > > > Rename struct device to struct _device > > [...] > > Not that a name matters much but struct _device gives me a sense that > the struct is ancillary. Whereas freebsd_device or fbsd_device is more > descriptive and gives the struct the status it deserves. It should not be needed, AFAIR, as device_t is one of a few properly opaque typedefs for (opaque) struct pointers. Bruce had explained this in detail a couple of times, at least: https://lists.freebsd.org/pipermail/svn-src-head/2011-October/030894.html https://lists.freebsd.org/pipermail/svn-src-head/2016-May/085790.html ./danfe