Date: Tue, 6 Mar 2001 18:25:32 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: audit@freebsd.org, doc@freebsd.org Subject: review request: ifconfig support for wireless card Message-ID: <20010306182532.A14442@Odin.AC.HMC.Edu>
next in thread | raw e-mail | index | archive | help
--EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline [Cross-posted message, please trim you're replies as appropriate.] I'd like to request review of a PR I just submitted as: conf/25577: [PATCH] ifconfig support for wireless network cards http://www.FreeBSD.org/cgi/query-pr.cgi?pr=3D25577 WARNING: Use the patch at the URL below rather then the one in the PR. As I was typing this message I realized I'd missed a critical suser() check in the an driver. http://www.one-eyed-alien.net/~brooks/FreeBSD/ifconfig.diff I'm also looking for a commiter to work with me to get this committed. This patch provides ifconfig support for wireless network rendering wicontrol and ancontrol unnecessary 99% of the time. By way of example, my /etc/start_if.an0 went from: ancontrol -i an0 -o 1 ancontrol -i an0 -n SSID ancontrol -i an0 -K 1 ancontrol -i an0 -W 1 to: ifconfig an0 ssid SSID wepmode on Support is included for wi and an cards since those are the ones I have and the most modern ones as well. Partial support for awi is also included, but is not ready for commit. These patches are against -current. I'll have tested stable patches in a couple of days once I get an extra laptop shipped from the office. -audit: There should be no issues in ifconfig since it runs unprivileged, but there might be issues in the driver code since I did have to use suser there. In fact, I noticed as I was typing this that I'd screwed it up in the an driver. -doc: This patch contains a patch to the ifconfig man page documenting the new commands. It also contains a new ieee80211.4 man page documenting the new ioctl interface I have added. These are my first significant attempts at man page modification/writing so there are bound to be issues. Let me know what you think. -- Brooks -- Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE6pZwbXY6L6fI4GtQRAs7pAJoDWt8lb3xzcW7479nXCnBZfhBcIQCeOyxG HZMcLSmTRbvfglFpN+X6enk= =Wcx3 -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010306182532.A14442>