From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Jun 5 19:20:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id CA67F32D for ; Wed, 5 Jun 2013 19:20:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id B0A9F1C43 for ; Wed, 5 Jun 2013 19:20:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r55JK0vW010323 for ; Wed, 5 Jun 2013 19:20:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r55JK01A010322; Wed, 5 Jun 2013 19:20:00 GMT (envelope-from gnats) Resent-Date: Wed, 5 Jun 2013 19:20:00 GMT Resent-Message-Id: <201306051920.r55JK01A010322@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Boris Samorodov Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id ADCE3EA for ; Wed, 5 Jun 2013 19:11:38 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) by mx1.freebsd.org (Postfix) with ESMTP id 86CA21BD2 for ; Wed, 5 Jun 2013 19:11:38 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r55JBc9l031836 for ; Wed, 5 Jun 2013 19:11:38 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r55JBcK6031835; Wed, 5 Jun 2013 19:11:38 GMT (envelope-from nobody) Message-Id: <201306051911.r55JBcK6031835@oldred.freebsd.org> Date: Wed, 5 Jun 2013 19:11:38 GMT From: Boris Samorodov To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/179344: [patch] x11-wm/fluxbox: rename option PDF -> PDFDOCS and some more X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jun 2013 19:20:00 -0000 >Number: 179344 >Category: ports >Synopsis: [patch] x11-wm/fluxbox: rename option PDF -> PDFDOCS and some more >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Wed Jun 05 19:20:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Boris Samorodov >Release: FreeBSD 9-i386 >Organization: BSDprint >Environment: FreeBSD srv.bb.tel.ru 9.1-STABLE FreeBSD 9.1-STABLE #9 r250778: Sat May 18 23:01:30 SAMT 2013 bsam@srv.bb.tel.ru:/usr/obj/usr/src/sys/BB i386 >Description: Yesterday I installed a brand new PC. When installing x11-wm/fluxbox I was curious what is the option "PDF document support". At a nearer glance it happened to be only an option to install PDF documentation. It seems to me that it should be an other option, say PDFDOCS. >How-To-Repeat: Do "make configure" for x11-wm/fluxbox. >Fix: . introduce a new option PDFDOCS (rather then PDF); . sort options *_DESC; . remove the indefinite article from COMMENT. Patch attached with submission follows: Index: Makefile =================================================================== --- Makefile (revision 320012) +++ Makefile (working copy) @@ -9,7 +9,7 @@ EXTRACT_ONLY= ${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX} MAINTAINER= beat@FreeBSD.org -COMMENT= A small and fast window manager based on BlackBox +COMMENT= Small and fast window manager based on BlackBox RUN_DEPENDS= xmessage:${PORTSDIR}/x11/xmessage @@ -25,14 +25,15 @@ fluxbox-style.5 DOCSVERSION= 20060629 -OPTIONS_DEFINE= DOCS DOCHTML PDF DEBUG GNOME IMLIB2 XINERAMA \ +OPTIONS_DEFINE= DOCS DOCHTML PDFDOCS DEBUG GNOME IMLIB2 XINERAMA \ XRENDER NLS SLIT REMEMBER TOOLBAR OPTIONS_DEFAULT= XRENDER SLIT REMEMBER TOOLBAR DOCHTML_DESC= Install html documentation -XRENDER_DESC= Enable xrender support +PDFDOCS_DESC= Build and/or install PDF documentation +REMEMBER_DESC= Enable remember feature SLIT_DESC= Enable slit feature -REMEMBER_DESC= Enable remember feature TOOLBAR_DESC= Enable toolbar feature +XRENDER_DESC= Enable xrender support .include @@ -51,7 +52,7 @@ PLIST_SUB+= DOCHTML:="@comment " .endif -.if ${PORT_OPTIONS:MPDF} +.if ${PORT_OPTIONS:MPDFDOCS} # http://fluxbox.org/docbook/en/pdf/ MASTER_SITES+= ${MASTER_SITE_LOCAL:S,%SUBDIR%,mezz,}:pdf \ http://people.freebsd.org/~mezz/distfiles/:pdf @@ -136,7 +137,7 @@ @${INSTALL_DATA} ${WRKSRC}/${i} ${DOCSDIR} .endfor .endif -.if ${PORT_OPTIONS:MPDF} +.if ${PORT_OPTIONS:MPDFDOCS} @${MKDIR} ${DOCSDIR}/pdf @${INSTALL_DATA} ${DISTDIR}/fluxbook-${DOCSVERSION}.pdf \ ${DOCSDIR}/pdf/ >Release-Note: >Audit-Trail: >Unformatted: