Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 17 Jun 2004 00:51:36 -0700 (PDT)
From:      Nate Lawson <nate@root.org>
To:        =?UTF-8?B?U8O4cmVuIFNjaG1pZHQ=?= <sos@DeepCore.dk>
Cc:        cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h
Message-ID:  <20040617004344.I39135@root.org>
In-Reply-To: <40D131B9.1080803@DeepCore.dk>
References:  <20040615110334.37E3516A4E8@hub.freebsd.org> <20040616155348.M36231@root.org> <20040616161507.W36231@root.org> <40D131B9.1080803@DeepCore.dk>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 17 Jun 2004, [UTF-8] S=C3=B8ren Schmidt wrote:
> Nate Lawson wrote:
> > On Wed, 16 Jun 2004, Nate Lawson wrote:
> >
> >>On Tue, 15 Jun 2004, S=C3=B8ren Schmidt wrote:
> >>
> >>>sos         2004-06-15 11:02:09 UTC
> >>>
> >>>  FreeBSD src repository
> >>>
> >>>  Modified files:
> >>>    sys/dev/ata          ata-chipset.c ata-pci.c ata-pci.h
> >>>  Log:
> >>>  Increase robustness of SATA handling.
> >>>
> >>>  Revision  Changes    Path
> >>>  1.72      +142 -42   src/sys/dev/ata/ata-chipset.c
> >>>  1.85      +48 -46    src/sys/dev/ata/ata-pci.c
> >>>  1.32      +1 -0      src/sys/dev/ata/ata-pci.h
> >>
> >>Since the "commit message words per lines changed" stat is 4.8% here, l=
et
> >>me try to give more detail from reading the diff.
> >
> > BTW, a typical stat for you is around 100%.  :)
>
> You know, now that I think of it, since you apparently have endless
> amounts of sparetime to nitpick my commit logs, I'll just leave it from
> now on and let you fill in the blanks.
>
> "Have a nice day"

In case it wasn't readily apparent, the above means that I think normally
you do a more complete job of indicating changes in commit logs.  In this
particular case, there were some pretty extensive changes there not
described in the message.

As for lots of spare time, it was significantly diminished today when
instead of coding, I used it trying to do a floppy install since a
use-after-free bug causes a panic when booting a kernel with INVARIANTS
from cdrom (i.e. installing via JPSNAP).

But we're even on that account since I still haven't fixed the
"eventhandler causes a hang on batteries" bug on your laptop.  :)

-Nate



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040617004344.I39135>