Date: Thu, 25 Jan 2001 18:39:24 +0100 (CET) From: Paul Herman <pherman@frenchfries.net> To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu> Cc: jayanth <jayanth@yahoo-inc.com>, <net@FreeBSD.ORG> Subject: Re: I have delayed ACK problems Message-ID: <Pine.BSF.4.32.0101251814480.11792-200000@husten.security.at12.de> In-Reply-To: <200101251617.LAA83006@khavrinen.lcs.mit.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-1724782094-980443456=:11792 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII Content-ID: <Pine.BSF.4.32.0101251832311.11792@husten.security.at12.de> On Thu, 25 Jan 2001, Garrett Wollman wrote: > <<On Thu, 25 Jan 2001 00:25:10 -0800, jayanth <jayanth@yahoo-inc.com> said: > > > could you test this patch and compare the results. > > By generating an ACK for every segment with the TH_PSH flag set > > I found a significant increase in throughput. > > I don't think this is right. I don't think it is either -- trying it with the rmt(8) results in each mss packet geting it's own ACK, which is the same behaviour as turning of delayed acks all together. This morning I came up with this patch, which *seems* to have solved both problems: 1) the rmt(8) problem Bruce wrote about and 2) my problem with the Solaris <-> FreeBSD problem I was experiencing. Thing is, I'm no TCP expert, and I am way out of my league on this. In fact, I'm certain it breaks something (for one the delayed ack counter no longer runs up, hmmm, and a few connections will stall), but maybe it's a start. Whatever happened to TF_DELACK anyway? -Paul. --0-1724782094-980443456=:11792 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="delack-current.patch" Content-Transfer-Encoding: BASE64 Content-ID: <Pine.BSF.4.32.0101251839240.11792@husten.security.at12.de> Content-Description: Content-Disposition: attachment; filename="delack-current.patch" SW5kZXg6IHRjcF9pbnB1dC5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpS Q1MgZmlsZTogL2hvbWUvbmN2cy9zcmMvc3lzL25ldGluZXQvdGNwX2lucHV0 LmMsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjEyMQ0KZGlmZiAtdSAtcjEu MTIxIHRjcF9pbnB1dC5jDQotLS0gdGNwX2lucHV0LmMJMjAwMC8xMi8xNSAy MTo0NTo0OQkxLjEyMQ0KKysrIHRjcF9pbnB1dC5jCTIwMDEvMDEvMjUgMTc6 MzY6MjENCkBAIC0xNzgsOSArMTc4LDE0IEBADQogCWlmICgodGgpLT50aF9z ZXEgPT0gKHRwKS0+cmN2X254dCAmJiBcDQogCSAgICBMSVNUX0VNUFRZKCYo dHApLT50X3NlZ3EpICYmIFwNCiAJICAgICh0cCktPnRfc3RhdGUgPT0gVENQ U19FU1RBQkxJU0hFRCkgeyBcDQotCQlpZiAodGNwX2RlbGFja19lbmFibGVk KSBcDQotCQkJY2FsbG91dF9yZXNldCh0cC0+dHRfZGVsYWNrLCB0Y3BfZGVs YWNrdGltZSwgXA0KLQkJCSAgICB0Y3BfdGltZXJfZGVsYWNrLCB0cCk7IFwN CisJCWlmICh0Y3BfZGVsYWNrX2VuYWJsZWQpIHsgXA0KKwkJCWlmICh0aC0+ dGhfZmxhZ3MgJiBUSF9QVVNIKSB7IFwNCisJCQkJdHAtPnRfZmxhZ3MgfD0g VEZfQUNLTk9XOyBcDQorCQkJCWNhbGxvdXRfcmVzZXQodHAtPnR0X2RlbGFj aywgdGNwX2RlbGFja3RpbWUsIHRjcF90aW1lcl9kZWxhY2ssIHRwKTsgXA0K KwkJCX0gXA0KKwkJCWVsc2UgXA0KKwkJCQl0cC0+dF9mbGFncyB8PSBURl9E RUxBQ0s7IFwNCisJCX0gXA0KIAkJZWxzZSBcDQogCQkJdHAtPnRfZmxhZ3Mg fD0gVEZfQUNLTk9XOyBcDQogCQkodHApLT5yY3Zfbnh0ICs9ICoodGxlbnAp OyBcDQpAQCAtOTY3LDggKzk3MiwxMyBAQA0KIAkJCXNiYXBwZW5kKCZzby0+ c29fcmN2LCBtKTsNCiAJCQlzb3J3YWtldXAoc28pOw0KIAkJCWlmICh0Y3Bf ZGVsYWNrX2VuYWJsZWQpIHsNCi0JICAgICAgICAgICAgICAgICAgICAgICAg Y2FsbG91dF9yZXNldCh0cC0+dHRfZGVsYWNrLCB0Y3BfZGVsYWNrdGltZSwN Ci0JICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRjcF90aW1lcl9kZWxh Y2ssIHRwKTsNCisJCQkJaWYgKHRoLT50aF9mbGFncyAmIFRIX1BVU0gpIHsN CisJCQkJCXRwLT50X2ZsYWdzIHw9IFRGX0FDS05PVzsNCisJCSAgICAgICAg ICAgICAgICAgICAgICAgIGNhbGxvdXRfcmVzZXQodHAtPnR0X2RlbGFjaywg dGNwX2RlbGFja3RpbWUsDQorCQkgICAgICAgICAgICAgICAgICAgICAgICAg ICAgdGNwX3RpbWVyX2RlbGFjaywgdHApOw0KKwkJCQl9DQorCQkJCWVsc2UN CisJCQkJCXRwLT50X2ZsYWdzIHw9IFRGX0RFTEFDSzsNCiAJCQl9IGVsc2Ug ew0KIAkJCQl0cC0+dF9mbGFncyB8PSBURl9BQ0tOT1c7DQogCQkJCXRjcF9v dXRwdXQodHApOw0KSW5kZXg6IHRjcF9vdXRwdXQuYw0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQ0KUkNTIGZpbGU6IC9ob21lL25jdnMvc3JjL3N5cy9uZXRp bmV0L3RjcF9vdXRwdXQuYyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNDgN CmRpZmYgLXUgLXIxLjQ4IHRjcF9vdXRwdXQuYw0KLS0tIHRjcF9vdXRwdXQu YwkyMDAwLzEwLzI3IDExOjQ1OjQxCTEuNDgNCisrKyB0Y3Bfb3V0cHV0LmMJ MjAwMS8wMS8yNSAxNzozNjoyMQ0KQEAgLTkxMyw3ICs5MTMsNyBAQA0KIAlp ZiAod2luID4gMCAmJiBTRVFfR1QodHAtPnJjdl9ueHQrd2luLCB0cC0+cmN2 X2FkdikpDQogCQl0cC0+cmN2X2FkdiA9IHRwLT5yY3Zfbnh0ICsgd2luOw0K IAl0cC0+bGFzdF9hY2tfc2VudCA9IHRwLT5yY3Zfbnh0Ow0KLQl0cC0+dF9m bGFncyAmPSB+VEZfQUNLTk9XOw0KKwl0cC0+dF9mbGFncyAmPSB+KFRGX0FD S05PV3xURl9ERUxBQ0spOw0KIAlpZiAodGNwX2RlbGFja19lbmFibGVkKQ0K IAkJY2FsbG91dF9zdG9wKHRwLT50dF9kZWxhY2spOw0KIAlpZiAoc2VuZGFs b3QgJiYgKCF0Y3BfZG9fbmV3cmVubyB8fCAtLW1heGJ1cnN0KSkNCkluZGV4 OiB0Y3BfdGltZXIuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZp bGU6IC9ob21lL25jdnMvc3JjL3N5cy9uZXRpbmV0L3RjcF90aW1lci5jLHYN CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zOQ0KZGlmZiAtdSAtcjEuMzkgdGNw X3RpbWVyLmMNCi0tLSB0Y3BfdGltZXIuYwkyMDAwLzEwLzAyIDE1OjAwOjEz CTEuMzkNCisrKyB0Y3BfdGltZXIuYwkyMDAxLzAxLzI1IDE3OjM2OjIxDQpA QCAtMTczLDExICsxNzMsMTMgQEANCiAJCXNwbHgocyk7DQogCQlyZXR1cm47 DQogCX0NCi0JY2FsbG91dF9kZWFjdGl2YXRlKHRwLT50dF9kZWxhY2spOw0K LQ0KLQl0cC0+dF9mbGFncyB8PSBURl9BQ0tOT1c7DQotCXRjcHN0YXQudGNw c19kZWxhY2srKzsNCi0JKHZvaWQpIHRjcF9vdXRwdXQodHApOw0KKwlpZiAo dHAtPnRfZmxhZ3MgJiBURl9ERUxBQ0spIHsNCisJCWNhbGxvdXRfZGVhY3Rp dmF0ZSh0cC0+dHRfZGVsYWNrKTsNCisJCXRwLT50X2ZsYWdzICY9IH5URl9E RUxBQ0s7DQorCQl0cC0+dF9mbGFncyB8PSBURl9BQ0tOT1c7DQorCQl0Y3Bz dGF0LnRjcHNfZGVsYWNrKys7DQorCQkodm9pZCkgdGNwX291dHB1dCh0cCk7 DQorCQl9DQogCXNwbHgocyk7DQogfQ0KIA0K --0-1724782094-980443456=:11792-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.32.0101251814480.11792-200000>