From owner-svn-src-head@freebsd.org Wed Mar 8 21:55:15 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B2C43D03A91; Wed, 8 Mar 2017 21:55:15 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (glebi.us [96.95.210.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9A1BE1E8A; Wed, 8 Mar 2017 21:55:14 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id v28LtEe7004728 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 8 Mar 2017 13:55:14 -0800 (PST) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id v28LtE0M004727; Wed, 8 Mar 2017 13:55:14 -0800 (PST) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 8 Mar 2017 13:55:14 -0800 From: Gleb Smirnoff To: Andriy Gapon Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r314862 - head/sys/modules/qlxgbe Message-ID: <20170308215514.GQ1044@FreeBSD.org> References: <201703071543.v27FhnoL024242@repo.freebsd.org> <20170307221733.GN1044@FreeBSD.org> <70fcdcf4-cfa5-2382-ea60-55ac1a91e06b@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <70fcdcf4-cfa5-2382-ea60-55ac1a91e06b@FreeBSD.org> User-Agent: Mutt/1.7.2 (2016-11-26) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 21:55:15 -0000 On Wed, Mar 08, 2017 at 01:00:30AM +0200, Andriy Gapon wrote: A> On 08/03/2017 00:17, Gleb Smirnoff wrote: A> > On Tue, Mar 07, 2017 at 03:43:49PM +0000, Andriy Gapon wrote: A> > A> Author: avg A> > A> Date: Tue Mar 7 15:43:49 2017 A> > A> New Revision: 314862 A> > A> URL: https://svnweb.freebsd.org/changeset/base/314862 A> > A> A> > A> Log: A> > A> qlxgbe: add GCC_MS_EXTENSIONS to CFLAGS to make old base GCC happy A> > A> A> > A> The module uses unnamed structure and union fields and base GCC in A> > A> stable/10 doesn't like it. A> > A> I think that that is a C11 feature, so it is courteous of more modern A> > A> compilers to not complain about it when compiling in C99 mode. A> > A> > There are a lot of code in kernel, that uses anonymous structs and unions. A> > This feature is enabled globally. Why does this module need special treatment? A> A> That's a good question and I don't have a good answer to it. A> All I can say is that a GCC build of GENERIC and modules failed in that fashion A> only for this module (in stable/10). A> Maybe I described the problem incorrectly. Then, a proper explanation is welcome. In head this is fixed properly: https://svnweb.freebsd.org/base?view=revision&revision=278913 Can you please move your fix to stable/10 and revert it in head? -- Totus tuus, Glebius.