From owner-freebsd-ports@FreeBSD.ORG  Mon Jul 28 04:44:01 2003
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3A43337B407; Mon, 28 Jul 2003 04:44:01 -0700 (PDT)
Received: from obsecurity.dyndns.org
	(adsl-63-207-60-135.dsl.lsan03.pacbell.net [63.207.60.135])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2C84443FB1; Mon, 28 Jul 2003 04:44:00 -0700 (PDT)
	(envelope-from kris@obsecurity.org)
Received: from rot13.obsecurity.org (rot13.obsecurity.org [10.0.0.5])
	by obsecurity.dyndns.org (Postfix) with ESMTP
	id 57FA766BE5; Mon, 28 Jul 2003 04:43:51 -0700 (PDT)
Received: by rot13.obsecurity.org (Postfix, from userid 1000)
	id 3C3BA830; Mon, 28 Jul 2003 04:43:51 -0700 (PDT)
Date: Mon, 28 Jul 2003 04:43:51 -0700
From: Kris Kennaway <kris@obsecurity.org>
To: Tilman Linneweh <arved@FreeBSD.org>
Message-ID: <20030728114351.GA53070@rot13.obsecurity.org>
References: <200307272105.h6RL5BTo000730@helo.liwing.de>
	<20030727221222.GA93833@huckfinn.arved.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030727221222.GA93833@huckfinn.arved.de>
User-Agent: Mutt/1.4.1i
cc: ports@FreeBSD.org
cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/36112: [PATCH] New feature for whole ports tree: GS_PORT
	variable
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Jul 2003 11:44:01 -0000

On Mon, Jul 28, 2003 at 12:12:22AM +0200, Tilman Linneweh wrote:

> Just picking a random PR.
> Instead of adding knobs to every port, a more
> generic solution might be appropriate, e.g. a bsd.port.mk patch.
> 
> 
> Oh, and I am not the first one with this idea.
> 
> PR 36112 by lev tries to introduce a IMHO better solution.

I thought I had replied recently to that PR (I'll add this mail as a
reply to that PR so we can record the rest of this thread).  I also
like this approach, but would prefer a more verbose variable name
(i.e. GHOSTSCRIPT_PORT) so that it's less cryptic.

I'm not sure about the need for GS_PORTSUFFIX though: if someone wants
to avoid X11 support then they would set GHOSTSCRIPT_PORT to
print/ghostscript-gnu-nox11 (and set WITHOUT_X11) so that none of
their ports that use gs pull in the X dependency.  ImageMagick just
happens to be about the only port that provides for this facility at
the moment, by checking WITHOUT_X11 explicitly.

Kris